1372022 - nsDisplayListBuilder::AddToWillChangeBudget does unnecessary hashtable lookups

Status: RESOLVED FIXED

(Core :: Web Painting, enhancement, P2)

Comment 1

[Mats Palmgren (inactive)]

Attachment: Replace a series of Contains+Put+Get+Put hashtable lookups with a single LookupForAdd call

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8876512 [details] [diff] [review]
Replace a series of Contains+Put+Get+Put hashtable lookups with a single LookupForAdd call

Review of attachment 8876512 [details] [diff] [review]:
-----------------------------------------------------------------

::: layout/painting/nsDisplayList.cpp
@@ +1739,5 @@
>                      gWillChangeAreaMultiplier < budgetLimit;
>  
>    if (onBudget) {
>      budget.mBudget += cost;
> +    willChangeBudgetEntry.Data() = budget;

If the type of `budget` was something expensive to copy, this code would not be so great, but it's not so bad this way, I guess.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7161c9f36756
Replace a series of Contains+Put+Get+Put hashtable lookups with a single LookupForAdd call.  r=froydnj

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/7161c9f36756