Closed
Bug 1372068
Opened 7 years ago
Closed 7 years ago
stylo: Don't traverse the whole subtree if there are no dependencies from stylesheets.
Categories
(Core :: CSS Parsing and Computation, enhancement, P1)
Core
CSS Parsing and Computation
Tracking
()
RESOLVED
FIXED
People
(Reporter: emilio, Assigned: emilio)
References
Details
Attachments
(2 files)
Turns out that the reason why iteration takes so much part of the time in bug 1372061 is because we're basically doing no work. And that is because mozreview adds empty stylesheets everywhere (!), so we end up doing all the traversal work (since we didn't find a scope that we couldn't reach), yet we have no actual work to do. Shrug
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
| Comment hidden (mozreview-request) |
|
||
Comment 5•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8876552 [details] Bug 1372068: Don't try to go through the whole subtree if there aren't actually any invalidations. https://reviewboard.mozilla.org/r/147886/#review152700
Attachment #8876552 -
Flags: review?(cam) → review+
|
|
||
Comment 6•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8876553 [details] Bug 1372068: Move one-off checks out of the recursive function. https://reviewboard.mozilla.org/r/147888/#review152702
Attachment #8876553 -
Flags: review?(cam) → review+
|
||
Updated•7 years ago
|
Assignee: nobody → emilio+bugs
Priority: -- → P1
|
||
Comment 7•7 years ago
|
||
Have the patches landed to Servo side? If not, any reason we shouldn't?
Flags: needinfo?(emilio+bugs)
|
Assignee | |
Comment 8•7 years ago
|
||
Yes: https://github.com/servo/servo/commit/36bac588630c6b49f20fea176a8e81c7bff7442b https://github.com/servo/servo/commit/6b0f4c04108b02490f3ed7db23b21222fdb50cbc
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(emilio+bugs)
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•