Closed Bug 1372097 Opened 2 years ago Closed 2 years ago

[Pointer Event] Implement tangential pressure and twist on Mac

Categories

(Core :: DOM: Events, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: stone, Assigned: stone)

Details

Attachments

(1 file, 4 obsolete files)

No description provided.
Assignee: nobody → sshih
Attachment #8876655 - Attachment is obsolete: true
Attachment #8876656 - Attachment is obsolete: true
Attachment #8884732 - Flags: review?(bugs)
Comment on attachment 8884732 [details] [diff] [review]
Implement tangential pressure and twist on Mac

Are the values in the right range?
tangentialPressure should be [-1,1] and twist [0,359]
I don't have a mac at hand right now to test.

Perhaps mstange could review this.
Attachment #8884732 - Flags: review?(mstange)
Attachment #8884732 - Flags: review?(bugs)
Attachment #8884732 - Flags: feedback+
Comment on attachment 8884732 [details] [diff] [review]
Implement tangential pressure and twist on Mac

Review of attachment 8884732 [details] [diff] [review]:
-----------------------------------------------------------------

Have you tested this to confirm that the values are in the right range? I don't have a way to test it.
Attachment #8884732 - Flags: review?(mstange) → review+
tweak the patch to ensure the twist value is in the range of 0-359.
Attachment #8884732 - Attachment is obsolete: true
Attachment #8885578 - Attachment is obsolete: true
Attachment #8885580 - Flags: review?(mstange)
Priority: -- → P1
Comment on attachment 8885580 [details] [diff] [review]
Implement tangential pressure and twist on Mac

Review of attachment 8885580 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/cocoa/nsChildView.mm
@@ +5390,5 @@
>    aOutGeckoEvent->inputSource = nsIDOMMouseEvent::MOZ_SOURCE_PEN;
>    aOutGeckoEvent->tiltX = lround([aPointerEvent tilt].x * 90);
>    aOutGeckoEvent->tiltY = lround([aPointerEvent tilt].y * 90);
> +  aOutGeckoEvent->tangentialPressure = [aPointerEvent tangentialPressure];
> +  // Make sure the twist value is in the rage of 0-359.

rage -> range
Attachment #8885580 - Flags: review?(mstange) → review+
Pushed by sshih@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb3323715527
Implement tangential pressure and twist on Mac. r=mstange.
https://hg.mozilla.org/mozilla-central/rev/bb3323715527
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.