Closed
Bug 1372097
Opened 7 years ago
Closed 7 years ago
[Pointer Event] Implement tangential pressure and twist on Mac
Categories
(Core :: DOM: Events, enhancement, P1)
Core
DOM: Events
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: stone, Assigned: stone)
Details
Attachments
(1 file, 4 obsolete files)
1.37 KB,
patch
|
mstange
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → sshih
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
Attachment #8876655 -
Attachment is obsolete: true
Assignee | ||
Comment 3•7 years ago
|
||
Attachment #8876656 -
Attachment is obsolete: true
Assignee | ||
Updated•7 years ago
|
Attachment #8884732 -
Flags: review?(bugs)
Comment 4•7 years ago
|
||
Comment on attachment 8884732 [details] [diff] [review] Implement tangential pressure and twist on Mac Are the values in the right range? tangentialPressure should be [-1,1] and twist [0,359] I don't have a mac at hand right now to test. Perhaps mstange could review this.
Attachment #8884732 -
Flags: review?(mstange)
Attachment #8884732 -
Flags: review?(bugs)
Attachment #8884732 -
Flags: feedback+
Comment 5•7 years ago
|
||
Comment on attachment 8884732 [details] [diff] [review] Implement tangential pressure and twist on Mac Review of attachment 8884732 [details] [diff] [review]: ----------------------------------------------------------------- Have you tested this to confirm that the values are in the right range? I don't have a way to test it.
Attachment #8884732 -
Flags: review?(mstange) → review+
Assignee | ||
Comment 6•7 years ago
|
||
tweak the patch to ensure the twist value is in the range of 0-359.
Attachment #8884732 -
Attachment is obsolete: true
Assignee | ||
Comment 7•7 years ago
|
||
Attachment #8885578 -
Attachment is obsolete: true
Assignee | ||
Updated•7 years ago
|
Attachment #8885580 -
Flags: review?(mstange)
Updated•7 years ago
|
Priority: -- → P1
Comment 8•7 years ago
|
||
Comment on attachment 8885580 [details] [diff] [review] Implement tangential pressure and twist on Mac Review of attachment 8885580 [details] [diff] [review]: ----------------------------------------------------------------- ::: widget/cocoa/nsChildView.mm @@ +5390,5 @@ > aOutGeckoEvent->inputSource = nsIDOMMouseEvent::MOZ_SOURCE_PEN; > aOutGeckoEvent->tiltX = lround([aPointerEvent tilt].x * 90); > aOutGeckoEvent->tiltY = lround([aPointerEvent tilt].y * 90); > + aOutGeckoEvent->tangentialPressure = [aPointerEvent tangentialPressure]; > + // Make sure the twist value is in the rage of 0-359. rage -> range
Attachment #8885580 -
Flags: review?(mstange) → review+
Assignee | ||
Comment 9•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a044c01a9de787cd270136773ee7bb8884f84f3b
Comment 10•7 years ago
|
||
Pushed by sshih@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/bb3323715527 Implement tangential pressure and twist on Mac. r=mstange.
Comment 11•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/bb3323715527
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•