1372097 - [Pointer Event] Implement tangential pressure and twist on Mac

Status: RESOLVED FIXED

(Core :: DOM: Events, enhancement, P1)

Comment 1

[Ming-Chou Shih [:stone]]

Attachment: Implement tangential pressure and twist on Mac

Comment 2

[Ming-Chou Shih [:stone]]

Attachment: Implement tangential pressure and twist on Mac

Comment 3

[Ming-Chou Shih [:stone]]

Attachment: Implement tangential pressure and twist on Mac

Comment 4

[Olli Pettay [:smaug][[e-mail]]]

Comment on attachment 8884732 [details] [diff] [review]
Implement tangential pressure and twist on Mac

Are the values in the right range?
tangentialPressure should be [-1,1] and twist [0,359]
I don't have a mac at hand right now to test.

Perhaps mstange could review this.

Comment 5

[Markus Stange [:mstange]]

Comment on attachment 8884732 [details] [diff] [review]
Implement tangential pressure and twist on Mac

Review of attachment 8884732 [details] [diff] [review]:
-----------------------------------------------------------------

Have you tested this to confirm that the values are in the right range? I don't have a way to test it.

Comment 6

[Ming-Chou Shih [:stone]]

Attachment: Implement tangential pressure and twist on Mac

tweak the patch to ensure the twist value is in the range of 0-359.

Comment 7

[Ming-Chou Shih [:stone]]

Attachment: Implement tangential pressure and twist on Mac

Comment 8

[Markus Stange [:mstange]]

Comment on attachment 8885580 [details] [diff] [review]
Implement tangential pressure and twist on Mac

Review of attachment 8885580 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/cocoa/nsChildView.mm
@@ +5390,5 @@
>    aOutGeckoEvent->inputSource = nsIDOMMouseEvent::MOZ_SOURCE_PEN;
>    aOutGeckoEvent->tiltX = lround([aPointerEvent tilt].x * 90);
>    aOutGeckoEvent->tiltY = lround([aPointerEvent tilt].y * 90);
> +  aOutGeckoEvent->tangentialPressure = [aPointerEvent tangentialPressure];
> +  // Make sure the twist value is in the rage of 0-359.

rage -> range

Comment 9

[Ming-Chou Shih [:stone]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a044c01a9de787cd270136773ee7bb8884f84f3b

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb3323715527
Implement tangential pressure and twist on Mac. r=mstange.

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/bb3323715527