[Pointer Event] Implement tangential pressure and twist on Mac

RESOLVED FIXED in Firefox 56

Status

()

Core
DOM: Events
P1
normal
RESOLVED FIXED
6 months ago
4 months ago

People

(Reporter: stone, Assigned: stone)

Tracking

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment, 4 obsolete attachments)

Comment hidden (empty)
(Assignee)

Updated

6 months ago
Assignee: nobody → sshih
(Assignee)

Comment 1

6 months ago
Created attachment 8876655 [details] [diff] [review]
Implement tangential pressure and twist on Mac
(Assignee)

Comment 2

6 months ago
Created attachment 8876656 [details] [diff] [review]
Implement tangential pressure and twist on Mac
Attachment #8876655 - Attachment is obsolete: true
(Assignee)

Comment 3

5 months ago
Created attachment 8884732 [details] [diff] [review]
Implement tangential pressure and twist on Mac
Attachment #8876656 - Attachment is obsolete: true
(Assignee)

Updated

5 months ago
Attachment #8884732 - Flags: review?(bugs)

Comment 4

5 months ago
Comment on attachment 8884732 [details] [diff] [review]
Implement tangential pressure and twist on Mac

Are the values in the right range?
tangentialPressure should be [-1,1] and twist [0,359]
I don't have a mac at hand right now to test.

Perhaps mstange could review this.
Attachment #8884732 - Flags: review?(mstange)
Attachment #8884732 - Flags: review?(bugs)
Attachment #8884732 - Flags: feedback+
Comment on attachment 8884732 [details] [diff] [review]
Implement tangential pressure and twist on Mac

Review of attachment 8884732 [details] [diff] [review]:
-----------------------------------------------------------------

Have you tested this to confirm that the values are in the right range? I don't have a way to test it.
Attachment #8884732 - Flags: review?(mstange) → review+
(Assignee)

Comment 6

5 months ago
Created attachment 8885578 [details] [diff] [review]
Implement tangential pressure and twist on Mac

tweak the patch to ensure the twist value is in the range of 0-359.
Attachment #8884732 - Attachment is obsolete: true
(Assignee)

Comment 7

5 months ago
Created attachment 8885580 [details] [diff] [review]
Implement tangential pressure and twist on Mac
Attachment #8885578 - Attachment is obsolete: true
(Assignee)

Updated

5 months ago
Attachment #8885580 - Flags: review?(mstange)
Priority: -- → P1
Comment on attachment 8885580 [details] [diff] [review]
Implement tangential pressure and twist on Mac

Review of attachment 8885580 [details] [diff] [review]:
-----------------------------------------------------------------

::: widget/cocoa/nsChildView.mm
@@ +5390,5 @@
>    aOutGeckoEvent->inputSource = nsIDOMMouseEvent::MOZ_SOURCE_PEN;
>    aOutGeckoEvent->tiltX = lround([aPointerEvent tilt].x * 90);
>    aOutGeckoEvent->tiltY = lround([aPointerEvent tilt].y * 90);
> +  aOutGeckoEvent->tangentialPressure = [aPointerEvent tangentialPressure];
> +  // Make sure the twist value is in the rage of 0-359.

rage -> range
Attachment #8885580 - Flags: review?(mstange) → review+
(Assignee)

Comment 9

4 months ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a044c01a9de787cd270136773ee7bb8884f84f3b

Comment 10

4 months ago
Pushed by sshih@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/bb3323715527
Implement tangential pressure and twist on Mac. r=mstange.
https://hg.mozilla.org/mozilla-central/rev/bb3323715527
Status: NEW → RESOLVED
Last Resolved: 4 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.