1372266 - stylo: consider returning 'InvalidValue' error while parsing invalid values

Status: NEW

(Core :: CSS Parsing and Computation, enhancement, P4)

Description

[Jeremy Chen ([e-mail])]

Currently, we return StyleParseError::UnspecifiedError [1] for invalid values in many places. However, the actual error is that we're parsing invalid values. Xidorn suggests maybe we could use something like PropertyDeclarationParseError::InvalidValue instead.


[1] http://searchfox.org/mozilla-central/rev/d840ebd5858a61dbc1622487c1fab74ecf235e03/servo/components/style/properties/longhand/font.mako.rs#1563

Comment 1

[Jeremy Chen ([e-mail])]

Hi Josh, since you're the author of these changes, we'd like to have your feedback before going any further.

Comment 2

[Josh Matthews [:jdm]]

UnspecifiedError is intended as a placeholder for code that could benefit from returning more specific errors indicating what actually went wrong. I do not think that returning StyleParseError::PropertyValue(PropertyValueParseError::InvalidValue) will be a meaningful improvement at the moment, however.

Comment 3

[Jeremy Chen ([e-mail])]

Lower the priority and un-assign myself according to comment 2.

Comment 4

[Firefox Bug Husbandry Bot]

https://wiki.mozilla.org/Bug_Triage/Projects/Bug_Handling/Bug_Husbandry#Move_fix-optionals