1372274 - Console::StartTimer/StopTimer does unnecessary hashtable lookups

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement, P2)

Comment 1

[Mats Palmgren (:mats)]

Attachment: Use LookupForAdd instead of Get+Put, and LookupRemoveIf instead of Get+Remove, to avoid unnecessary hashtable lookups

Comment 2

[Nathan Froyd [:froydnj]]

Comment on attachment 8876775 [details] [diff] [review]
Use LookupForAdd instead of Get+Put, and LookupRemoveIf instead of Get+Remove, to avoid unnecessary hashtable lookups

Review of attachment 8876775 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/console/Console.cpp
@@ +2087,5 @@
> +  mTimerRegistry.LookupRemoveIf(key,
> +    [&found, &entry] (const DOMHighResTimeStamp& aValue) {
> +      entry = aValue;
> +      found = true;
> +      return true;  // remove it

Maybe we should change this to some sort of eRemove/eKeep constant so that we don't have to insert these kind of constants.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/40a933ae0d2f
Use LookupForAdd instead of Get+Put, and LookupRemoveIf instead of Get+Remove, to avoid unnecessary hashtable lookups.  r=froydnj

Comment 4

[Sebastian Hengst [:aryx] (needinfo on intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/40a933ae0d2f