HTMLAllCollection::GetDocumentAllList does unnecessary hashtable lookups

RESOLVED FIXED in Firefox 56

Status

()

Product:
Core
Component:
DOM: Core & HTML
P2
normal
RESOLVED FIXED
Reported:
2 months ago
Modified:
2 months ago

People

(Reporter: Mats Palmgren (vacation - back in August), Assigned: Mats Palmgren (vacation - back in August))

Tracking

({perf})

Version:
Trunk
Target:
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

Use LookupForAdd instead of GetWeak+Put to avoid unnecessary hashtable lookups
1.45 KB, patch
froydnj
: review+
Details | Diff | Splinter Review
Comment hidden (empty)
(Assignee)

Comment 1

•
2 months ago 
Created attachment 8876881 [details] [diff] [review]
Use LookupForAdd instead of GetWeak+Put to avoid unnecessary hashtable lookups
Attachment #8876881 - Flags: review?(nfroyd)

Updated

•
2 months ago
Attachment #8876881 - Flags: review?(nfroyd) → review+

Comment 2

•
2 months ago 
Pushed by mpalmgren@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d8e1cda03282
Use LookupForAdd instead of GetWeak+Put to avoid unnecessary hashtable lookups.  r=froydnj

Comment 3

•
2 months ago
bugherder 
https://hg.mozilla.org/mozilla-central/rev/d8e1cda03282
Status: NEW → RESOLVED
Last Resolved: 2 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.