Closed Bug 1372372 Opened 8 years ago Closed 8 years ago

Capitalize all user initials in revision list

Categories

(Tree Management :: Treeherder, enhancement, P5)

Product:
Tree Management
Component:
Treeherder
Type:
enhancement

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: jfrench, Assigned: jfrench)

Details

Attachments

(1 file)

[treeherder] tojon:capitalize-revision-initials > mozilla:master
47 bytes, text/x-github-pull-request
camd
: review+
Details | Review
Some user initials in push revision history could be better parsed, for example: sotaro.ikeda.g@gmail.com registered their user name as just 'sotaro', with no last name. This results in a single lowercase 's' in the revision user push initials, which is smaller and more difficult to read than a typical 'AB' two cap characters for most other users. So perhaps we can capitalize all leading characters in the userTokens name string when we're building the revisions.
Assignee: nobody → tojonmz
Status: NEW → ASSIGNED
Attachment #8876899 - Flags: review?(cdawson)
Made a suggestion / comment in the PR. Thanks for hitting this! :)
Attachment #8876899 - Flags: review?(cdawson) → review-
Comment on attachment 8876899 [details] [review] [treeherder] tojon:capitalize-revision-initials > mozilla:master Yup, that seems to work fine also in testing :)
Attachment #8876899 - Flags: review- → review?(cdawson)
Comment on attachment 8876899 [details] [review] [treeherder] tojon:capitalize-revision-initials > mozilla:master Great! Thanks for the PR! :)
Attachment #8876899 - Flags: review?(cdawson) → review+
Marking fixed per above merge.
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: