Closed Bug 1372465 Opened 7 years ago Closed 7 years ago

[Fennec][HLS][Test] Make sure GeckoHLSPlayer is used by correct MediaResource/MediaDemuxer pair.

Categories

(Firefox for Android Graveyard :: Audio/Video, defect, P3)

Product:
Firefox for Android Graveyard
Component:
Audio/Video
Type:
defect

Tracking

(firefox56 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: kikuo, Assigned: kikuo)

References

Details

Attachments

(1 file)

Bug 1372465 - Make sure GeckoHlsPlayer is used by correct media components.
59 bytes, text/x-review-board-request
jwwang
: review+
Details 
Per Bug 1368954 Comment 19, A test should be provided to make sure GeckoHLSPlayer is used between correct MediaResource / MediaDemuxer pair.
Priority: -- → P3
Attachment #8888193 - Flags: review?(jwwang)
Comment on attachment 8888193 [details]
Bug 1372465 - Make sure GeckoHlsPlayer is used by correct media components.

https://reviewboard.mozilla.org/r/159128/#review164522

::: dom/media/test/test_hls_player_independency.html:35
(Diff revision 2)
> +  var v4x3_videoHeight = 0;
> +  var v16x9_videoWidth = 0;
> +  var v16x9_videoHeight = 0;
> +
> +  function isDone() {
> +    return v16x9_videoWidth == 416 && v16x9_videoHeight == 234 && v4x3_videoWidth == 400 && v4x3_videoHeight == 300;

The test case will time out if width/heigh goes wrong. I would prefer:
1. check width and hieght in 'ended' handlers respectively.
2. call SimpleTest.finish() when we get 2 'ended' events.
Attachment #8888193 - Flags: review?(jwwang) → review+
Comment on attachment 8888193 [details]
Bug 1372465 - Make sure GeckoHlsPlayer is used by correct media components.

https://reviewboard.mozilla.org/r/159128/#review164522

> The test case will time out if width/heigh goes wrong. I would prefer:
> 1. check width and hieght in 'ended' handlers respectively.
> 2. call SimpleTest.finish() when we get 2 'ended' events.

Thanks !  That's neater
Comment on attachment 8888193 [details]
Bug 1372465 - Make sure GeckoHlsPlayer is used by correct media components.

https://reviewboard.mozilla.org/r/159128/#review164556

It's more informative to use is() instead of ok()
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5da3d2a15f40&selectedJob=115907803

looks like something weird happening on Android 4.2 API 15+ ... investigating
Comment on attachment 8888193 [details]
Bug 1372465 - Make sure GeckoHlsPlayer is used by correct media components.

https://reviewboard.mozilla.org/r/159128/#review166176

Test failed on Fennec (Android 4.2), becase only 1 decoder can be created when API version < 18 [1].
I think it's ok to skip this test on 4.2 since we're not able to play 2 video at the same time no matter it's HLS or not.

[1] http://searchfox.org/mozilla-central/rev/3a3af33f513071ea829debdfbc628caebcdf6996/dom/media/MediaPrefs.h#224-227
Pushed by kikuo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1eaacee91b1b
Make sure GeckoHlsPlayer is used by correct media components. r=jwwang
https://hg.mozilla.org/mozilla-central/rev/1eaacee91b1b
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: