[Fennec][HLS][Test] Make sure GeckoHLSPlayer is used by correct MediaResource/MediaDemuxer pair.

RESOLVED FIXED in Firefox 56

Status

()

P3
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: kikuo, Assigned: kikuo)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
Per Bug 1368954 Comment 19, A test should be provided to make sure GeckoHLSPlayer is used between correct MediaResource / MediaDemuxer pair.
Priority: -- → P3
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

a year ago
Attachment #8888193 - Flags: review?(jwwang)

Comment 3

a year ago
mozreview-review
Comment on attachment 8888193 [details]
Bug 1372465 - Make sure GeckoHlsPlayer is used by correct media components.

https://reviewboard.mozilla.org/r/159128/#review164522

::: dom/media/test/test_hls_player_independency.html:35
(Diff revision 2)
> +  var v4x3_videoHeight = 0;
> +  var v16x9_videoWidth = 0;
> +  var v16x9_videoHeight = 0;
> +
> +  function isDone() {
> +    return v16x9_videoWidth == 416 && v16x9_videoHeight == 234 && v4x3_videoWidth == 400 && v4x3_videoHeight == 300;

The test case will time out if width/heigh goes wrong. I would prefer:
1. check width and hieght in 'ended' handlers respectively.
2. call SimpleTest.finish() when we get 2 'ended' events.
Attachment #8888193 - Flags: review?(jwwang) → review+
(Assignee)

Comment 4

a year ago
mozreview-review-reply
Comment on attachment 8888193 [details]
Bug 1372465 - Make sure GeckoHlsPlayer is used by correct media components.

https://reviewboard.mozilla.org/r/159128/#review164522

> The test case will time out if width/heigh goes wrong. I would prefer:
> 1. check width and hieght in 'ended' handlers respectively.
> 2. call SimpleTest.finish() when we get 2 'ended' events.

Thanks !  That's neater
Comment hidden (mozreview-request)
(Assignee)

Comment 6

a year ago
mozreview-review
Comment on attachment 8888193 [details]
Bug 1372465 - Make sure GeckoHlsPlayer is used by correct media components.

https://reviewboard.mozilla.org/r/159128/#review164556

It's more informative to use is() instead of ok()
Comment hidden (mozreview-request)
(Assignee)

Comment 8

a year ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=5da3d2a15f40&selectedJob=115907803

looks like something weird happening on Android 4.2 API 15+ ... investigating
(Assignee)

Comment 9

a year ago
mozreview-review
Comment on attachment 8888193 [details]
Bug 1372465 - Make sure GeckoHlsPlayer is used by correct media components.

https://reviewboard.mozilla.org/r/159128/#review166176

Test failed on Fennec (Android 4.2), becase only 1 decoder can be created when API version < 18 [1].
I think it's ok to skip this test on 4.2 since we're not able to play 2 video at the same time no matter it's HLS or not.

[1] http://searchfox.org/mozilla-central/rev/3a3af33f513071ea829debdfbc628caebcdf6996/dom/media/MediaPrefs.h#224-227
Comment hidden (mozreview-request)

Comment 11

a year ago
Pushed by kikuo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1eaacee91b1b
Make sure GeckoHlsPlayer is used by correct media components. r=jwwang

Comment 12

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1eaacee91b1b
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.