Closed Bug 1372488 Opened 8 years ago Closed 8 years ago

Make counter style 'disc' not overridable

Categories

(Core :: CSS Parsing and Computation, enhancement)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: xidorn, Assigned: xidorn)

References

Details

Attachments

(1 file)

Bug 1372488 - Make counter style 'disc' not overridable.
59 bytes, text/x-review-board-request
dbaron
: review+
Details
As I proposed in w3c/csswg-drafts#1521. This would allow us to avoid building counter style for initial struct. That would simplify our handling of counter style in stylo.
Assignee: nobody → xidorn+moz
Also I suspect that, before this change, CounterStyleManager::IsInitial() actually never returns true after the first restyle, because creating nsStyleList would always insert the "disc" item into the table. That said, doing this should allow us to actually benefit from skipping flushing counter style manager in many pages.
I think this is a reasonable change to make. Not allowing @counter-style rules to change the meaning of the initial value of list-style-type seems like a good restriction to add. The one thing I'm confused about is layout/reftests/counter-style/redefine-attr-mapping-ref.html. Why does the reference have triangles rather than discs?
Flags: needinfo?(xidorn+moz)
The changes to redefine-attr-mapping-ref.html correspond to changes in redefine-attr-mapping.html, where I just removed all instances which may lead to using 'disc'. That test is for checking the given predefined counter styles are indeed overridden. Since 'disc' is no longer overridable, I just remove them from it. (Not sure what your question really is...)
Flags: needinfo?(xidorn+moz)
Comment on attachment 8877063 [details] Bug 1372488 - Make counter style 'disc' not overridable. https://reviewboard.mozilla.org/r/148406/#review154356 Oops, for some reason I was thinking those lines were added rather than removed. r=dbaron
Attachment #8877063 - Flags: review?(dbaron) → review+
hg error in cmd: hg push -r tip ssh://hg.mozilla.org/integration/autoland: pushing to ssh://hg.mozilla.org/integration/autoland searching for changes remote: adding changesets remote: adding manifests remote: adding file changes remote: added 1 changesets with 9 changes to 9 files remote: (dc243c10abeb modifies servo/components/style/stylesheets/rule_parser.rs from Servo; not enforcing peer review) remote: (1 changesets contain changes to protected servo/ directory: dc243c10abeb) remote: ************************************************************************ remote: you do not have permissions to modify files under servo/ remote: remote: the servo/ directory is kept in sync with the canonical upstream remote: repository at https://github.com/servo/servo remote: remote: changes to servo/ are only allowed by the syncing tool and by sheriffs remote: performing cross-repository "merges" remote: remote: to make changes to servo/, submit a Pull Request against the servo/servo remote: GitHub project remote: ************************************************************************ remote: transaction abort! remote: rollback completed remote: pretxnchangegroup.e_prevent_vendored hook failed abort: push failed on remote
Servo PR: servo/servo#17353
Pushed by xquan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e2f80edad993 Make counter style 'disc' not overridable. r=dbaron
https://hg.mozilla.org/mozilla-central/rev/e2f80edad993
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: