137253 - Rewrap: Don't touch long words

Status: VERIFIED FIXED

(Core :: DOM: Editor, defect)

Description

[Boris 'pi' Piwinger]

This is not limited to a particular Mozilla version.
Compare bug 124099 (Akana wants this one -> Assigning)

Rewrap (plain text editor) breaks long words like URLs.

Expected: Long words are not touched.

Rationale: It is not possible for the receiver to unwrap broken URLs or other
long words to recreate paragraphs.

Solution: Do line breaks only at white space.

pi

Comment 1

[Akkana Peck]

This should be easy to do, and I agree it's evil that we break urls when we rewrap.

Comment 2

[Akkana Peck]

Attachment: A fix

Here's a fix.  Sorry this took so long ...  I kept getting ideas about how I
could leverage the wrapping code in the serializers and avoid us having to have
two separate implementations of this logic, but none of the rewrites I tried
ever worked out.

This patch is a simple fix that addresses only the problem at hand.  It should
be safe, but to be sure we should test the cases in bug 121046 and bug 112139,
which touched code near this change in order to cure two different hangs. 
Unfortunately the mail compose window doesn't come up in today's build, so that
test will have to wait.  But if someone could review it in the meantime, that
would get us started ...

Comment 3

[Kathleen :Brade]

Comment on attachment 89999 [details] [diff] [review]
A fix

r=brade (assuming the bugs mentioned above have been tested with satisfactory
results)

Comment 4

[Akkana Peck]

I tested the attachments in those two bugs; no regression of the problems
reported there.  I think we're good to go.

Kin, could you sr this patch, please?

Comment 5

[kinmoz]

Comment on attachment 89999 [details] [diff] [review]
A fix

sr=[e-mail]

Comment 6

[Boris 'pi' Piwinger]

Did you already check the patch in? If so when?

pi

Comment 7

[Akkana Peck]

The tree has been closed since the patch was sr'ed.  I have requested driver
approval for 1.1.

Comment 8

[Akkana Peck]

Fixed in the trunk.  I haven't gotten a reply about the 1.1 branch; pester
[e-mail] if you want it in.

Comment 9

[Boris 'pi' Piwinger]

Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.1b) Gecko/2002080820

Fix WFM.

pi

Comment 10

[sairuh (rarely reading bugmail)]

vrfy'd fixed with 2003.04.10 comm bits on linux rh8.0.

Comment 11

[Prognathous]

I'm not sure whether the fix for this bug was what now makes Mozilla so
inconvenient when typing text with long URLs, but if it does, then this is
actually a regression.

For example, pasting the URL below in the "Additional Comments" field (where I'm
writing this comment), causes Mozilla to display a horizontal scroll bar, while
under IE such long URLs flow to the next line.

http://bugzilla.mozilla.org/buglist.cgi?bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED

In my opinion, using word wrap is easier for users to handle.

Prog.