1372564 - top mouse target area too small

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[Tom Schneider]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.6; rv:43.0) Gecko/20100101 Firefox/43.0 SeaMonkey/2.40
Build ID: 20160120191716

Steps to reproduce:

SeaMonkey 2.40 (on an old Mac OS X, no upgrade available):  The space at the top of the browser window can be used to move the window.  The entire space is available for this and it is very convenient.  To do this I place my mouse cursor into the top of the window, click and hold down the mouse left button and move the mouse.  The window moves.  On a new Mac OS X (10.11.6) with SeaMonkey 2.46 only a thin sliver at the top of the window can be used.  This makes it hard to move the window


Actual results:

On an old 2.40 SeaMonkey, the window target area is large and moving the window
is easy.

on a new 2.46 SeaMonkey the window target area it tiny and it is hard to move the window because I often miss the target.


Expected results:

Apparently a recent upgrade of SeaMonkey reduced the active target area.
Please revert to allow the entire space at the top of the window,
excluding icons of course.

Comment 1

[Frank-Rainer Grahl (:frg)]

could you upload a picture.

Comment 2

[Tom Schneider]

(In reply to Frank-Rainer Grahl (:frg) from comment #1)
> could you upload a picture.

There isn't anything to see.  It's where the mouse is active.  I would
have to annotate an image and getting the locations of where things
are active would be really tricky.  So, instead, here's a sketch in
ascii.

===================== top of SeaMonkey window
Title of page
                      <= empty space here
---  top of icons
stuff of the window
===================== bottom of SeaMonkey window

In the old SeaMonkey essentially all of the empty space and the title
line is active and one can grab there to move the window.  Apparently
in the new one most of the empty space is NOT grabbable.  This really
confounded me for a month or two earlier this year as I could not
understand why I could not move the windows around.  Sometimes they
would move, many times my attempts would fail.  Now that I recognize
the problem, I am forced to carefully place the mouse in the line of
the title, which is picky and difficult.  The space that is used
should be ALL of the empty space that is not the icons.  (On the
ancient NeWS windowing system from Sun, which was smartly based on
PostScript, this could have been done easily - by having a complex
area.  I don't know how easy that is now with the current window
systems.)

Comment 3

[Stefan [:stefanh]]

Hmm (haven't really investigated this, just throwing out some ideas), it might be that we don't use the windowdragbox binding or it has become obsolete.

Comment 4

[Stefan [:stefanh]]

I tested with both 2.40 and 2.46 on MacOS Sierra, but I don't notice any difference. In fact, the draggable area is possibly larger on 2.46 for me. We're talking millimeters here, but I do feel that the draggable area extends a bit more downwards on 2.46.

Comment 5

[Tom Schneider]

Attachment: SeaMonkey 2.46 mouse could not move window at this position

Millimeters (mm) do matter because mouse positioning is that precise. 
However, but we cannot describe this problem to each other in mm
because display sizes differ.  My SeaMonkey 2.46 system is a laptop
with half the display area of my 2.40 system.

Here's a precise description based on landmarks.

On the top of the SeaMonkey window is the title line in black. 
Directly below that there is a large yellow typing/URL bar.  To the
left of the yellow bar is an octagon stop sign (shaded red with a
white X and the word 'Stop' below it).  The octagon extends higher
than the yellow bar.

On SeaMonkey 2.40 I can easily move the window by targeting anywhere
above the bar, even below the octagon's top.  On SeaMonkey 2.46 I
cannot move the window until my mouse is about half of the way up
between the bar and the top of the display.  I was able to confirm
this by expanding the window using (alt command + after setting zoom
in Preferences Accessibility).

Summary:  the dragable area in SeaMonkey 2.46 is half what it used to
be in SeaMonkey 2.40.

https://www.itg.ias.edu/content/keyboard-shortcuts-capture-screen-shot-mac-os-x
command-shift-3 = full screen shot

I put the mouse where it no longer could drag the window and took the
attached screen shot.

Comment 6

[Frank-Rainer Grahl (:frg)]

I didn't try with 2.40 yet but 2.53a1 works normally for me. The whole titlebar area is draggable. On OSX 10.12.5 at least there is also a slight change in the grey tones masking the draggable area which starts just above the octagon. So overall like stefanh I couldn't reproduce your problem. 

What is the screen resolution of your laptop.

But some other apps like the photo app have a titlebar twice as high. stefanh: Is it possible that just the icons changed and the height was adjusted automatically? 2.46 dropped support for older OSX versions.

You could try the latest unofficial version from Adrian. The official one will be build from the same source base and only contain minor changes which are compatible:

https://l10n.mozilla-community.org/~akalla/unofficial/seamonkey/nightly/latest-comm-esr-mac64/

Please back up your profile if for some reason you need to go back to 2.46 afterwards.

Comment 7

[Frank-Rainer Grahl (:frg)]

Could you also check in about.config what the setting layout.css.devPixelsPerPx is set to. Should be -1.0

Comment 8

[Tom Schneider]

(In reply to Frank-Rainer Grahl (:frg) from comment #6)
> I didn't try with 2.40 yet but 2.53a1 works normally for me. The whole
> titlebar area is draggable. On OSX 10.12.5 at least there is also a slight
> change in the grey tones masking the draggable area which starts just above
> the octagon. So overall like stefanh I couldn't reproduce your problem. 
> 
> What is the screen resolution of your laptop.

the "Built-in Display" is:
13.3-inch (1440x900)

> But some other apps like the photo app have a titlebar twice as high.
> stefanh: Is it possible that just the icons changed and the height was
> adjusted automatically? 2.46 dropped support for older OSX versions.
> 
> You could try the latest unofficial version from Adrian. The official one
> will be build from the same source base and only contain minor changes which
> are compatible:
> 
> https://l10n.mozilla-community.org/~akalla/unofficial/seamonkey/nightly/
> latest-comm-esr-mac64/
> 
> Please back up your profile if for some reason you need to go back to 2.46
> afterwards.

I can't upgrade on the old machine.  2.40 works there.

I'm using the latest SeaMonkey 2.46 on the new machine and that's
where the problem is.  It's OS X El Capitan 10.11.6.

Comment 9

[Tom Schneider]

(In reply to Frank-Rainer Grahl (:frg) from comment #7)
> Could you also check in about.config what the setting
> layout.css.devPixelsPerPx is set to. Should be -1.0

Yes, on 2.40 it is indeed -1.0

Comment 10

[Stefan [:stefanh]]

(In reply to Frank-Rainer Grahl (:frg) from comment #6)
> stefanh: Is it possible that just the icons changed and the height was
> adjusted automatically? 2.46 dropped support for older OSX versions.

But I don't see any difference between 2.40 and 2.46.

Tom, what happens if you run 2.40 on the new machine (with a new/different profile than the one you're using 2.46 with)?

Comment 11

[Tom Schneider]

(In reply to Stefan [:stefanh] from comment #10)
> Tom, what happens if you run 2.40 on the new machine (with a new/different
> profile than the one you're using 2.46 with)?

Fortunately I have the old dmg and was able to install it on the new machine.
Now I can run either one.  2.40 has full access to the entire space above
the URL box for dragging the window.  2.46 is about half that in the top half.
This is with the same profile.  I made a fresh profile and 2.40 is still
draggable but 2.46 is not.

Comment 12

[Stefan [:stefanh]]

Is this with the default theme? Any extensions installed? Can you try in safe mode with both 2.40 and 2.46 and see what happens?

Comment 13

[Tom Schneider]

(In reply to Stefan [:stefanh] from comment #12)
> Is this with the default theme? Any extensions installed? Can you try in
> safe mode with both 2.40 and 2.46 and see what happens?

On Mac OS X El Capitan 10.11.6
SeaMonkey 2.46 in safe mode: half draggable area.
SeaMonkey 2.40 in safe mode: full draggable area.

Comment 14

[Tom Schneider]

(In reply to Stefan [:stefanh] from comment #12)
> Is this with the default theme? Any extensions installed? Can you try in
> safe mode with both 2.40 and 2.46 and see what happens?

Also, I don't use themes, so I'm pretty sure it's the default theme.  Safe mode
turns off extensions, right?

Comment 15

[Stefan [:stefanh]]

(In reply to Tom Schneider from comment #14)
> Also, I don't use themes, so I'm pretty sure it's the default theme.

You could either be using Modern or the Default theme.

> Safe mode
> turns off extensions, right?

Yes.

I've had no luck reproducing this on 10.12. I'll see if I can reproduce on 10.9.

Comment 16

[Tom Schneider]

I have the same effect on another computer system:

Mac OS X Yosemite Version 10.10.5 
SeaMonkey version 2.46

This has the bug in which only half of the top space is draggable.

Comment 17

[Stefan [:stefanh]]

(In reply to Tom Schneider from comment #16)
> I have the same effect on another computer system:
> 
> Mac OS X Yosemite Version 10.10.5 
> SeaMonkey version 2.46
> 
> This has the bug in which only half of the top space is draggable.

Yeah, what you see on 2.46 is what I also see on 2.40. So for me it's the "normal" behavior. I'll have to see if I can reproduce the behavior you see in 2.40 (that's actually what I ment in my earlier comment about "reproduce").

From the screenshot it looks like you're using the default theme. Is there any difference in toolbar mode (small/large icons, with/without labels)?

Comment 18

[Tom Schneider]

(In reply to Stefan [:stefanh] from comment #12)
> Is this with the default theme? Any extensions installed? Can you try in
> safe mode with both 2.40 and 2.46 and see what happens?

Looking around I found that under View/Apply Theme I have 'Seamonkey Default Theme'
on both original systems.  I never play with this so it's probably true for all systems.

Comment 19

[Tom Schneider]

(In reply to Stefan [:stefanh] from comment #17)
...
> Yeah, what you see on 2.46 is what I also see on 2.40. So for me it's the
> "normal" behavior. I'll have to see if I can reproduce the behavior you see
> in 2.40 (that's actually what I ment in my earlier comment about
> "reproduce").

Oh.  Thanks for being more clear.  As you can see I've taken to calling the two
"half" and "full" dragable.

> From the screenshot it looks like you're using the default theme.

Correct.

> Is there any difference in toolbar mode (small/large icons, with/without labels)?

I looked around at preferences and pull-down menues but didn't find the controls for this.
Oh wait!  I remember - it's in the toolbar itself!  Sheesh.  it should also be in preferences?
Anyway ...

Interesting!  Right button click on both 2.40 and 2.46 activates
the menu to see 'Settings for this toolbar'.  But it activates
ONLY in the lower half of the dragable area in both cases!
That's a clue!!

Inference: maybe someone switched a variable (describing the dragable
area) to be the same as the toolbar setting instead of going the other
way to full setting!

2.40
Icons alone:
words go away, potentially dragable region is the same..
full region is dragable

2.46
Icons alone:
words go away, potentially dragable region is smaller.
lower half dragable, upper half not dragable

Inference: someone is dividing by two in the code somewhere!

Text alone:
Same effects as above but for a smaller area.

(It helps to use Alt-CMD+ to zoom in - settings in system
preferences/Universal Access need to be turned on for to work
probably.  This makes the effect really clear because it's larger. 
Alt-CMD- to zoom out again.)

Use small icons:
Same effects as above.

My normal settings are "Icons and Text" and not "Use small icons".
Apparently this is the "Default settings"

Comment 20

[Stefan [:stefanh]]

OK, so this only happens in the browser. I haven't noticed this before (I guess I seldom drag windows), but I noticed now that the draggable region is larger in mailNews. The reason for the "small" draggable region in the browser is that the region is set by css and we don't set it for the nav-bar-inner and the throbber-box. I have no idea why the draggable region is larger for Tom in 2.40, though.

I'm going to put up a patch for this, but I might not have the time until the weekend.

Tom,
If you know how to use userChrome.css hacks, you could fix this by adding the following rules to the userChrome.css file:

#throbber-box,
.nav-bar-class {
  -moz-window-dragging: drag !important;
}

(I haven't tried it, but it should work. The "!important" might not be needed, it's just to be on the safe side since I haven't tested it myself)

Comment 21

[Stefan [:stefanh]]

(In reply to Stefan [:stefanh] from comment #20)
> the following rules to the userChrome.css file:

Make that "following lines".

Comment 22

[Tom Schneider]

(In reply to Stefan [:stefanh] from comment #20)

> OK, so this only happens in the browser.

Where else might it happen?

> I haven't noticed this before (I
> guess I seldom drag windows), but I noticed now that the draggable region is
> larger in mailNews.

What's mailNews?  Assuming you mean the Mail program on Mac OS X,
that has a huge draggable area.

> The reason for the "small" draggable region in the
> browser is that the region is set by css and we don't set it for the
> nav-bar-inner and the throbber-box. I have no idea why the draggable region
> is larger for Tom in 2.40, though.

I suppose someone changed something ...

> I'm going to put up a patch for this, but I might not have the time until
> the weekend.
> 
> Tom,
> If you know how to use userChrome.css hacks, you could fix this by adding
> the following rules to the userChrome.css file:
> 
> #throbber-box,
> .nav-bar-class {
>   -moz-window-dragging: drag !important;
> }
> 
> (I haven't tried it, but it should work. The "!important" might not be
> needed, it's just to be on the safe side since I haven't tested it myself)

I didn't know about that but I googled:
https://www.google.com/search?&q=userChrome.css
and found
http://kb.mozillazine.org/index.php?title=UserChrome.css&printable=yes
Following those instructions:

% pwd
/Users/[user]/Library/Application Support/SeaMonkey/Profiles/[userid].default
% cat userChrome.css 
@namespace url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");
#throbber-box,
.nav-bar-class {
  -moz-window-dragging: drag !important;
}

I restarted SeaMonkey ... no effect on 2.46. :-(

Comment 23

[Stefan [:stefanh]]

(In reply to Tom Schneider from comment #22)
> (In reply to Stefan [:stefanh] from comment #20)
> 
> > OK, so this only happens in the browser.
> 
> Where else might it happen?

Well, it could have happened in the top toolbar in Composer, Mail & News and Address Book. But it doesn't ;-)
> 
> > I haven't noticed this before (I
> > guess I seldom drag windows), but I noticed now that the draggable region is
> > larger in mailNews.
> 
> What's mailNews?  Assuming you mean the Mail program on Mac OS X,
> that has a huge draggable area.

Yes.

> 
> > The reason for the "small" draggable region in the
> > browser is that the region is set by css and we don't set it for the
> > nav-bar-inner and the throbber-box. I have no idea why the draggable region
> > is larger for Tom in 2.40, though.
> 
> I suppose someone changed something ...

I don't see a larger draggable region in 2.40. I'm on 10.12, though - but I wonder if that's the reason.
 
> % pwd
> /Users/[user]/Library/Application Support/SeaMonkey/Profiles/[userid].default
> % cat userChrome.css 
> @namespace
> url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");
> #throbber-box,
> .nav-bar-class {
>   -moz-window-dragging: drag !important;
> }
> 
> I restarted SeaMonkey ... no effect on 2.46. :-(

Perhaps the file isn't in /Users/[user]/Library/Application Support/SeaMonkey/Profiles/[userid].default/chrome/? If you have a chrome dir, there's usually a file in there called userChrome-example.css which you can re-name.

Comment 24

[Stefan [:stefanh]]

(In reply to Stefan [:stefanh] from comment #23)
> > What's mailNews?  Assuming you mean the Mail program on Mac OS X,
> > that has a huge draggable area.
> 
> Yes.

Oops... No, I ment the Mail & Newsgroups application in SeaMonkey.

Comment 25

[Tom Schneider]

(In reply to Stefan [:stefanh] from comment #23)
> (In reply to Tom Schneider from comment #22)
> > (In reply to Stefan [:stefanh] from comment #20)
> > 
> > > OK, so this only happens in the browser.
> > Where else might it happen?
> Well, it could have happened in the top toolbar in Composer, Mail & News and
> Address Book. But it doesn't ;-)

Thanks for taking the time to explain.

> > % pwd
> > /Users/[user]/Library/Application Support/SeaMonkey/Profiles/[userid].default
> > % cat userChrome.css 
> > @namespace
> > url("http://www.mozilla.org/keymaster/gatekeeper/there.is.only.xul");
> > #throbber-box,
> > .nav-bar-class {
> >   -moz-window-dragging: drag !important;
> > }
> > 
> > I restarted SeaMonkey ... no effect on 2.46. :-(
> 
> Perhaps the file isn't in /Users/[user]/Library/Application
> Support/SeaMonkey/Profiles/[userid].default/chrome/? If you have a chrome
> dir, there's usually a file in there called userChrome-example.css which you
> can re-name.

Indeed there is a file named userChrome-example.css
in the chrome sub-directory!

When I moved the userChrome.css file there, SeaMonkey did not use the
larger draggable space.  So I closed down SeaMonkey and relaunched.

Now it uses the larger draggable area!!!

Good Job Sherlock!

Comment 26

[Stefan [:stefanh]]

Attachment: Add draggablity to more elements in the main toolbar

Perhaps you can test this. I added draggability to the throbber-box as well.

Comment 27

[Frank-Rainer Grahl (:frg)]

I didn't notice anything different from Windows and Linux but thery you could only drag in the titlebar anyway. Will check it out probably over the weekend but looks simple enough so should work fine.

Comment 28

[Frank-Rainer Grahl (:frg)]

Comment on attachment 8883078 [details] [diff] [review]
Add draggablity to more elements in the main toolbar

Works. Tested with a comm-esr52 build. I assume you want it there too so please ask IanN for approval.

Comment 29

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/comm-central/rev/19368fa161462406c87e19ca98be23b79b4c0457

Comment 30

[Stefan [:stefanh]]

Comment on attachment 8883078 [details] [diff] [review]
Add draggablity to more elements in the main toolbar

Low risk, Mac css change only.

Comment 31

[Ian Neal]

Comment on attachment 8883078 [details] [diff] [review]
Add draggablity to more elements in the main toolbar

a=me

Comment 32

[Stefan [:stefanh]]

https://hg.mozilla.org/releases/comm-esr52/rev/0f74bac5b77debff154a95fddc427bb1e00aebb4

Comment 33

[Stefan [:stefanh]]

Comment on attachment 8883078 [details] [diff] [review]
Add draggablity to more elements in the main toolbar

Actually, I believe we should take this for comm-beta (not just for comm-esr52) as well...

Comment 34

[Stefan [:stefanh]]

Comment on attachment 8883078 [details] [diff] [review]
Add draggablity to more elements in the main toolbar

Oh, wait - this is already in comm-beta...