Closed Bug 1372614 Opened 4 years ago Closed 4 years ago

Remove HTTP Pipelining preferences UI after bug 1340655 removed support for it

Categories

(SeaMonkey :: Preferences, enhancement)

SeaMonkey 2.51 Branch
enhancement
Not set
normal

Tracking

(seamonkey2.49esr unaffected, seamonkey2.51 wontfix, seamonkey2.53 fixed, seamonkey2.52 wontfix)

RESOLVED FIXED
seamonkey2.53
Tracking Status
seamonkey2.49esr --- unaffected
seamonkey2.51 --- wontfix
seamonkey2.53 --- fixed
seamonkey2.52 --- wontfix

People

(Reporter: rsx11m.pub, Assigned: rsx11m.pub)

Details

Attachments

(1 file)

As frg pointed out, bug 1340655 has removed the pipelining feature for HTTP/1.1 which has been experimental for ages anyway and superseded by other methods.

Consequently, network.http.pipelining.* and network.http.proxy.pipelining do no longer have any function, yet we are exposing the top-level enabling prefs in the Advanced > HTTP Networking prefpane.

Charge of this bug is to remove those from pref-http.{xul,js,dtd} along with respective Help content in cs_nav_prefs_advanced.xhtml.
Attached patch Proposed patchSplinter Review
This removes the two checkboxes and related logic.

I have retained the thin separator between the protocol and UA-string options.

Asking IanN for review as it involves Help-content changes, updating HTTP/1.1 to be the "current" protocol rather than the "new" one. Also, let me know if you want any further changes while I'm there.
Attachment #8877339 - Flags: review?(iann_bugzilla)
Comment on attachment 8877339 [details] [diff] [review]
Proposed patch

Stealing review. Tested and works as expected. Help content is and looks fine in my eyes.
Attachment #8877339 - Flags: review?(iann_bugzilla) → review+
Target milestone 2.53. 

I think it can ride the trains. If not please ask for beta approval.
Thanks for pushing. Yes, given that 2.52 won't be released as a final, no need for beta.
Target Milestone: --- → seamonkey2.53
You need to log in before you can comment on or make changes to this bug.