Upon clicking 'More' link in the Legacy extensions view, the Extensions tab gets highlighted

VERIFIED FIXED in Firefox 56

Status

()

Toolkit
Add-ons Manager
P2
minor
VERIFIED FIXED
6 months ago
5 months ago

People

(Reporter: kraj, Assigned: aswan)

Tracking

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 verified)

Details

(Whiteboard: triaged)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

(Reporter)

Description

6 months ago
Created attachment 8877229 [details]
extensions view get highlighted.gif

Firefox Nightly 56.0a1 (2017-06-12) (64-bit)

steps to reproduce:
1. On your nightly install a few legacy extensions like Adblock Plus, Video Download helper
2. In about:config, toggle the value of extensions.legacy.enabled to false
3. Load about:addons
4. Click on the Legacy Extensions. Notice that the tab is highlighted as long as you have that view open.
5. Click on the "More" link next to one of the legacy extensions
6. Notice what tab is highlighted in the menu

expected behavior:
As long as the user is viewing info about legacy extensions, the Legacy Extensions tab is highlighted

actual behavior:
Upon clicking 'More' link in the Legacy extensions view, the Extensions tab gets highlighted

Comment 1

6 months ago
awan wanted to verify before making any changes: Is the expected behavior Krupa describes what we are expecting?
Flags: needinfo?(emanuela)
Whiteboard: UX needed

Comment 2

6 months ago
Krupa is right: what she said is the expected behaviour.
Flags: needinfo?(emanuela)
(Assignee)

Updated

6 months ago
Assignee: nobody → aswan
Priority: -- → P2
Whiteboard: UX needed → triaged
Comment hidden (mozreview-request)
(Assignee)

Updated

5 months ago
Attachment #8890656 - Flags: review?(rhelmer)

Comment 4

5 months ago
mozreview-review
Comment on attachment 8890656 [details]
Bug 1372645 Highlight the legacy pane when showing details for a legacy addon

https://reviewboard.mozilla.org/r/161824/#review167382
Attachment #8890656 - Flags: review?(rhelmer) → review+

Comment 5

5 months ago
hg error in cmd: hg pull gecko -r 1152d1abafdbbe65892ea22de3b1519f7cb33fa2: pulling from https://reviewboard-hg.mozilla.org/gecko
abort: HTTP Error 500: Internal Server Error

Comment 6

5 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/a689645ca0f7
Highlight the legacy pane when showing details for a legacy addon r=rhelmer

Comment 7

5 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a689645ca0f7
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Created attachment 8891971 [details]
2017-07-31_1441.png

Confirm that this issue is fixed on Firefox 56.0a1 (2017-07-30/31) under Windows 10 64-bit and Mac OS X 10.12.3. “Legacy Extensions” tab is successfully highlighted while clicking “More” link from this tab.
Status: RESOLVED → VERIFIED
status-firefox56: fixed → verified
You need to log in before you can comment on or make changes to this bug.