Closed Bug 1372679 Opened 7 years ago Closed 7 years ago

stylo: Lots of time spent in rayon_core::latch::LockLatch::wait() when running VueJS

Categories

(Core :: CSS Parsing and Computation, defect)

Product:
Core
Component:
CSS Parsing and Computation
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: ehsan.akhgari, Unassigned)

References

(Blocks 1 open bug)

Details

See these profiles for example: https://perfht.ml/2ro19bq https://perfht.ml/2rnFEHI https://perfht.ml/2romHEz Test case: http://speedometer2.benj.me/InteractiveRunner.html?suite=VueJS-TodoMVC This is with my fast Linux machine, of course. Not sure if these lock waits are normal or too much, mostly filing to get this to your attention. If these waits are the minimum wait time waiting on the background threads to finish their work and there's nothing to improve on here feel free to close!
Blocks: stylo-perf
Summary: [stylo] Lots of time spent in rayon_core::latch::LockLatch::wait() when running VueJS → stylo: Lots of time spent in rayon_core::latch::LockLatch::wait() when running VueJS
(sorry for the terrible lag here) Those lock waits just mean that the main thread is paused because we're doing a parallel style traversal. So that's the amount of time we're spent restyling, and you just think of it as "time spent in ProcessPendingRestyles". Comparing gecko and stylo's restyling performance on that testcase is worth doing, but should probably happen as part of bug 1371496. Closing this bug, but feel free to reopen if I've missed any pieces.
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
You need to log in before you can comment on or make changes to this bug.