1372734 - Bugmail generated despite mail_delivery_method being set to 'None'

Status: NEW

(Bugzilla :: Email Notifications, defect)

Description

[louis.belleville1]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.11; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20170518000419

Steps to reproduce:

Set the parameters of the Bugzilla installation so that mail_delivery_method is 'None' and use_mailer_queue is false.

Submit a bug in that installation. The difference is most noticeable when submitting large bugs.


Actual results:

In Bugzilla::BugMail::sendMail, MessageToMTA(_generate_bugmail($vars)) will be called. This will generate the bugmail before calling Bugzilla::Mailer::MessageToMTA at which point the bugmail will be discarded since 'mail_delivery_method' is 'None'.

Since generating the bugmail usually takes much longer than simply adding the bug to the db this means most of the time is wasted


Expected results:

Either in Bugzilla::BugMail::sendMail or probably further up in Bugzilla::Bug::send_changes, the mail_delivery_method should have been checked, and since it is 'None' the entire sendMail step should be skipped.

Comment 1

[Dylan Hardison [:dylan] (he/him)]

That seems like a reasonable behavior

Comment 2

[Simon Green]

Attachment: bug1372734-v1.patch