Closed
Bug 1372839
Opened 7 years ago
Closed 7 years ago
ClearKeyUtils.cpp: unused value
Categories
(Core :: Audio/Video: GMP, defect, P3)
Core
Audio/Video: GMP
Tracking
()
RESOLVED
FIXED
mozilla57
| Tracking | Status | |
|---|---|---|
| firefox57 | --- | fixed |
People
(Reporter: Sylvestre, Assigned: Sylvestre)
References
(Blocks 1 open bug)
Details
(Keywords: coverity, Whiteboard: [CID 1286112])
Attachments
(1 file)
https://dxr.mozilla.org/mozilla-central/source/media/gmp-clearkey/0.1/ClearKeyUtils.cpp?q=ClearKeyUtils.cpp&redirect_type=direct#238 It gives the impression that sym is used when it is not the case
I think that `sym` should be tested for falseness, to break or return false in that case. (Or is backslash + null allowed in a string?)
|
||
Updated•7 years ago
|
Rank: 35
Priority: -- → P3
| Comment hidden (mozreview-request) |
|
||
Comment 3•7 years ago
|
||
| mozreview-review | ||
Comment on attachment 8895709 [details] Bug 1372839 - SkipString; Exit early if sym is not found https://reviewboard.mozilla.org/r/167010/#review172146 Thank you Sylvestre.
Attachment #8895709 -
Flags: review?(gsquelart) → review+
|
Assignee | |
Comment 4•7 years ago
|
||
De rien Gerald!
Pushed by sledru@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/01e2dfa7e58c SkipString; Exit early if sym is not found r=gerald
|
||
Comment 6•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/01e2dfa7e58c
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in
before you can comment on or make changes to this bug.
Description
•