Closed Bug 1372839 Opened 3 years ago Closed 3 years ago

ClearKeyUtils.cpp: unused value

Categories

(Core :: Audio/Video: GMP, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla57
Tracking Status
firefox57 --- fixed

People

(Reporter: Sylvestre, Assigned: Sylvestre)

References

(Blocks 1 open bug)

Details

(Keywords: coverity, Whiteboard: [CID 1286112])

Attachments

(1 file)

I think that `sym` should be tested for falseness, to break or return false in that case.
(Or is backslash + null allowed in a string?)
Rank: 35
Priority: -- → P3
Comment on attachment 8895709 [details]
Bug 1372839 - SkipString; Exit early if sym is not found

https://reviewboard.mozilla.org/r/167010/#review172146

Thank you Sylvestre.
Attachment #8895709 - Flags: review?(gsquelart) → review+
De rien Gerald!
Pushed by sledru@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/01e2dfa7e58c
SkipString; Exit early if sym is not found r=gerald
https://hg.mozilla.org/mozilla-central/rev/01e2dfa7e58c
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.