1372853 - Use nullptr in /netwerk (clang-tidy: modernize-use-nullptr)

Status: RESOLVED FIXED

(Core :: Networking, enhancement)

Description

[Jan Keromnes [:janx]]

In /netwerk/ there are several opportunities to use `nullptr` instead of `0` or `NULL`.

These can be automatically identified and acted on by the clang-tidy static analyzer (rule "modernize-use-nullptr").

Comment 1

[Jan Keromnes [:janx]]

Attachment: Use nullptr in /netwerk (clang-tidy: modernize-use-nullptr). r=

This patch was generated with the following command:

run-clang-tidy-4.0.py -p obj-x86_64-pc-linux-gnu/ -fix -checks=-*,modernize-use-nullptr netwerk/

Comment 2

[Jan Keromnes [:janx]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6e77935e3b1c

Comment 3

[Valentin Gosu [:valentin] (he/him)]

If you're looking for a reviewer I volunteer as tribute :)

Comment 4

[Jan Keromnes [:janx]]

Comment on attachment 8877524 [details] [diff] [review]
Use nullptr in /netwerk (clang-tidy: modernize-use-nullptr). r=

(In reply to Valentin Gosu [:valentin] from comment #3)
> If you're looking for a reviewer I volunteer as tribute :)

Yes please! Thank you for volunteering :)

Comment 5

[Valentin Gosu [:valentin] (he/him)]

Comment on attachment 8877524 [details] [diff] [review]
Use nullptr in /netwerk (clang-tidy: modernize-use-nullptr). r=

Review of attachment 8877524 [details] [diff] [review]:
-----------------------------------------------------------------

::: netwerk/protocol/http/nsHttpHandler.cpp
@@ +1898,5 @@
>      dec = q / (double) n;
>      count_n = 0;
>      p2 = q_Accept;
>      for (token = nsCRT::strtok(o_Accept, ",", &p);
> +         token != (char *) nullptr;

nit: I think the cast isn't necessary here.

@@ +1904,5 @@
>      {
>          token = net_FindCharNotInSet(token, HTTP_LWS);
>          char* trim;
>          trim = net_FindCharInSet(token, ";" HTTP_LWS);
> +        if (trim != (char*)nullptr)  // remove "; q=..." if present

nit: cast isn't necessary

Comment 6

[Jan Keromnes [:janx]]

Attachment: Use nullptr in /netwerk (clang-tidy: modernize-use-nullptr).

Thanks a lot Valentin! Nits addressed, still compiles without the unnecessary casts, r+ carried over.

Comment 7

[Jan Keromnes [:janx]]

Comment on attachment 8877524 [details] [diff] [review]
Use nullptr in /netwerk (clang-tidy: modernize-use-nullptr). r=

(I forgot to mark the old patch as obsolete)

Comment 8

[Jan Keromnes [:janx]]

Previous try run still applies and is fully green, please land this patch.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/561c612879c4
Use nullptr in /netwerk (clang-tidy: modernize-use-nullptr). r=valentin

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/561c612879c4