1372870 - Compiling with mingw-w64 based on GCC 6.3.0 breaks (operands to ?: have different types)

Status: RESOLVED FIXED

(Core :: Graphics: Layers, defect, P3)

Description

[Georg Koppen]

Compiling with mingw-w64 based on 6.3.0 gives me the following compile error:

/home/ubuntu/build/tor-browser/obj-mingw/dist/include/mozilla/layers/TextureD3D11.h: In member function 'virtual mozilla::layers::DataTextureSource* mozilla::layers::DataTextureSourceD3D11::AsDataTextureSource()':
/home/ubuntu/build/tor-browser/obj-mingw/dist/include/mozilla/layers/TextureD3D11.h:240:0: error: operands to ?: have different types 'mozilla::layers::DataTextureSourceD3D11*' and 'bool'
   virtual DataTextureSource* AsDataTextureSource() override { return mAllowTextureUploads ? this : false; }

This happens on an esr52 branch but looking at mozilla-central shows that the code in question did not change, so I guess that the issue is still there.

Comment 1

[Jacek Caban]

Attachment: fix

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/0298f22db7a5
Compiling with mingw-w64 based on GCC 6.3.0 breaks (operands to ?: have different types) r=mattwoodrow

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/0298f22db7a5