Closed
Bug 1372877
Opened 7 years ago
Closed 7 years ago
Use nullptr in /js (clang-tidy: modernize-use-nullptr)
Categories
(Core :: JavaScript Engine, enhancement)
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: janx, Assigned: janx)
References
(Blocks 1 open bug)
Details
Attachments
(1 file, 1 obsolete file)
1.46 KB,
patch
|
janx
:
review+
|
Details | Diff | Splinter Review |
In /js there are several opportunities to use `nullptr` instead of `0` or `NULL`. These can be automatically identified and acted on by the clang-tidy static analyzer (rule "modernize-use-nullptr").
Assignee | ||
Comment 1•7 years ago
|
||
This patch was generated with the following command: run-clang-tidy-4.0.py -p obj-x86_64-pc-linux-gnu/ -fix -checks=-*,modernize-use-nullptr js/
Assignee | ||
Comment 2•7 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=22e12f9efa50
Updated•7 years ago
|
Attachment #8877550 -
Flags: review+
Assignee | ||
Comment 3•7 years ago
|
||
Added "r=nbp", r+ carried over.
Attachment #8877606 -
Flags: review+
Assignee | ||
Updated•7 years ago
|
Attachment #8877550 -
Attachment is obsolete: true
Assignee | ||
Comment 4•7 years ago
|
||
R+ and try looks green (apart from 2 unrelated-looking oranges), so please land this patch.
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/e1386053622e Use nullptr in /js (clang-tidy: modernize-use-nullptr). r=nbp
Keywords: checkin-needed
Comment 6•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/e1386053622e
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•