MinGW Fails to build with --enable-accessibility

RESOLVED FIXED in Firefox 57

Status

()

enhancement
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: tjr, Assigned: tjr)

Tracking

(Blocks 1 bug)

Trunk
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

(Whiteboard: [tor 21240])

Attachments

(1 attachment)

Comment 1

2 years ago
FWIW: after bumping the mingw-w64 version we only need a small patch to build with accessibility support:

https://gitweb.torproject.org/tor-browser.git/commit/?h=tor-browser-52.2.0esr-7.5-1&id=84d370aab03e45fbafef90b0fd99153e45a1b64a
Blocks: 1263224
CC'ing aklotz since he probably knows best what the change from comment #1 would have.
Flags: needinfo?(aklotz)
(In reply to Georg Koppen from comment #1)
> FWIW: after bumping the mingw-w64 version we only need a small patch to
> build with accessibility support:
> 
> https://gitweb.torproject.org/tor-browser.git/commit/?h=tor-browser-52.2.
> 0esr-7.5-1&id=84d370aab03e45fbafef90b0fd99153e45a1b64a

This is fine. Send that review to me and I'll r+ it.
Flags: needinfo?(aklotz)

Comment 4

2 years ago
Thanks. I took our patch and applied it on top of m-c.

Updated

2 years ago
Attachment #8895319 - Flags: review?(aklotz)
Attachment #8895319 - Flags: review?(aklotz) → review+

Comment 5

2 years ago
Thanks.
Keywords: checkin-needed

Comment 6

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/64c054d2b58a
Fix broken mingw-w64 build with --enable-accessibility. r=aklotz
Keywords: checkin-needed

Comment 7

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/64c054d2b58a
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Whiteboard: [tor] → [tor 21240]
You need to log in before you can comment on or make changes to this bug.