Closed
Bug 1372959
Opened 7 years ago
Closed 7 years ago
MinGW Fails to build with --enable-accessibility
Categories
(Core :: Disability Access APIs, enhancement)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: tjr, Assigned: tjr)
References
(Blocks 1 open bug)
Details
(Whiteboard: [tor 21240])
Attachments
(1 file)
1.06 KB,
patch
|
bugzilla
:
review+
|
Details | Diff | Splinter Review |
Tor's patch is here: https://trac.torproject.org/projects/tor/attachment/ticket/21240/0001-Getting-Tor-Browser-to-build-with-accessibility-enab.patch
Comment 1•7 years ago
|
||
FWIW: after bumping the mingw-w64 version we only need a small patch to build with accessibility support: https://gitweb.torproject.org/tor-browser.git/commit/?h=tor-browser-52.2.0esr-7.5-1&id=84d370aab03e45fbafef90b0fd99153e45a1b64a
Blocks: 1263224
Comment 2•7 years ago
|
||
CC'ing aklotz since he probably knows best what the change from comment #1 would have.
Flags: needinfo?(aklotz)
Comment 3•7 years ago
|
||
(In reply to Georg Koppen from comment #1) > FWIW: after bumping the mingw-w64 version we only need a small patch to > build with accessibility support: > > https://gitweb.torproject.org/tor-browser.git/commit/?h=tor-browser-52.2. > 0esr-7.5-1&id=84d370aab03e45fbafef90b0fd99153e45a1b64a This is fine. Send that review to me and I'll r+ it.
Flags: needinfo?(aklotz)
Comment 4•7 years ago
|
||
Thanks. I took our patch and applied it on top of m-c.
Updated•7 years ago
|
Attachment #8895319 -
Flags: review?(aklotz)
Updated•7 years ago
|
Attachment #8895319 -
Flags: review?(aklotz) → review+
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/64c054d2b58a Fix broken mingw-w64 build with --enable-accessibility. r=aklotz
Keywords: checkin-needed
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/64c054d2b58a
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Updated•6 years ago
|
Whiteboard: [tor] → [tor 21240]
You need to log in
before you can comment on or make changes to this bug.
Description
•