Closed Bug 1372977 Opened 3 years ago Closed 3 years ago
Use nullptr in /media and /dom/media (clang-tidy: modernize-use-nullptr)
In /media and /dom/media there are several opportunities to use `nullptr` instead of `0` or `NULL`. These can be automatically identified and acted on by the clang-tidy static analyzer (rule "modernize-use-nullptr").
This patch was generated with the following command: run-clang-tidy-4.0.py -p obj-x86_64-pc-linux-gnu/ -fix -checks=-*,modernize-use-nullptr dom/media/,media/
Attachment #8877676 - Flags: review?(padenot)
more of the code in /media is from 3rd party libs, very few is our own code (the exception is media/libstagefright/bindings). So we shouldn't touch that, only makes resyncing with upstream difficult
Attachment #8877676 - Flags: review?(padenot) → review-
I omitted libstagefright and ffmpeg on purpose. Please indicate which files in my patch are from external libraries so I can omit any fixes there. Thanks!
all in media/ ? the one in dom/media are fine.
> all in media/ ? > > the one in dom/media are fine. Thanks! But media/mtransport/ should be fine (according to tools/rewriting/ThirdPartyPaths.txt). Paul, please have a look. https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5e3fec4f5bd863ddf7d072f40b7d8429c08f76f
Attachment #8881447 - Flags: review?(padenot)
Attachment #8877676 - Attachment is obsolete: true
Attachment #8881447 - Flags: review?(padenot) → review?(docfaraday)
Attachment #8881447 - Flags: review?(docfaraday) → review+
Thanks Paul and Byron! Rebased and updated to "r=bwc".
Attachment #8881987 - Flags: review+
Attachment #8881447 - Attachment is obsolete: true
Sheriffs, please land this patch.
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/fbfd540c840d Use nullptr in /media and /dom/media (clang-tidy: modernize-use-nullptr). r=bwc
You need to log in before you can comment on or make changes to this bug.