1372977 - Use nullptr in /media and /dom/media (clang-tidy: modernize-use-nullptr)

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, enhancement)

Description

[Jan Keromnes [:janx]]

In /media and /dom/media there are several opportunities to use `nullptr` instead of `0` or `NULL`.

These can be automatically identified and acted on by the clang-tidy static analyzer (rule "modernize-use-nullptr").

Comment 1

[Jan Keromnes [:janx]]

Attachment: Use nullptr in /media and /dom/media (clang-tidy: modernize-use-nullptr).

This patch was generated with the following command:

run-clang-tidy-4.0.py -p obj-x86_64-pc-linux-gnu/ -fix -checks=-*,modernize-use-nullptr dom/media/,media/

Comment 2

[Jan Keromnes [:janx]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=6502a04a86bf

Comment 3

[Jean-Yves Avenard [:jya]]

more of the code in /media is from 3rd party libs, very few is our own code (the exception is media/libstagefright/bindings).

So we shouldn't touch that, only makes resyncing with upstream difficult

Comment 4

[Jan Keromnes [:janx]]

I omitted libstagefright and ffmpeg on purpose. Please indicate which files in my patch are from external libraries so I can omit any fixes there. Thanks!

Comment 5

[Jean-Yves Avenard [:jya]]

all in media/ ?

the one in dom/media are fine.

Comment 6

[Jan Keromnes [:janx]]

Attachment: Use nullptr in /media and /dom/media (clang-tidy: modernize-use-nullptr).

> all in media/ ?
> 
> the one in dom/media are fine.

Thanks! But media/mtransport/ should be fine (according to tools/rewriting/ThirdPartyPaths.txt).

Paul, please have a look.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f5e3fec4f5bd863ddf7d072f40b7d8429c08f76f

Comment 7

[Jan Keromnes [:janx]]

Attachment: Use nullptr in /media and /dom/media (clang-tidy: modernize-use-nullptr).

Thanks Paul and Byron! Rebased and updated to "r=bwc".

Comment 8

[Jan Keromnes [:janx]]

Sheriffs, please land this patch.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fbfd540c840d
Use nullptr in /media and /dom/media (clang-tidy: modernize-use-nullptr). r=bwc

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/fbfd540c840d