Use context-fill in menuPanel.svg

RESOLVED WONTFIX

Status

()

Firefox
Theme
RESOLVED WONTFIX
a year ago
a year ago

People

(Reporter: johannh, Assigned: johannh)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(Assignee)

Description

a year ago
menuPanel.svg is one of the last remaining places where we use filters.svg#fill, which isn't great for performance. We should use context-fill instead.

Comment 1

a year ago
menuPanel.svg is going to go away with photon structure because the old panel menu will be dead. Is this really worth pursuing at this stage, just for 56?
Flags: needinfo?(jhofmann)
(Assignee)

Comment 2

a year ago
Right, I didn't realize that. It's not worth it, then. Thanks!
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Flags: needinfo?(jhofmann)
Resolution: --- → WONTFIX
(In reply to :Gijs from comment #1)
> menuPanel.svg is going to go away with photon structure because the old
> panel menu will be dead. Is this really worth pursuing at this stage, just
> for 56?

Is there a way of tracking this? Ideally a bug that we can mark as blocking bug 1358998 so that we are notified when that bug can be closed and the filter removed from filters.svg.
Flags: needinfo?(gijskruitbosch+bugs)

Comment 5

a year ago
(In reply to Jonathan Watt [:jwatt] from comment #3)
> (In reply to :Gijs from comment #1)
> > menuPanel.svg is going to go away with photon structure because the old
> > panel menu will be dead. Is this really worth pursuing at this stage, just
> > for 56?
> 
> Is there a way of tracking this? Ideally a bug that we can mark as blocking
> bug 1358998 so that we are notified when that bug can be closed and the
> filter removed from filters.svg.

I don't think we've filed explicit bugs on "remove everything obsoleted by photon" yet. Feel free to file bugs as you think is appropriate. It should probably depend on bug 1354086 being fixed, because I think right now buttons might still be using these icons in the permanent part of the overflow panel in photon (which should be fixed in that bug).
Flags: needinfo?(gijskruitbosch+bugs)
You need to log in before you can comment on or make changes to this bug.