1372990 - Use context-fill in menuPanel.svg

Status: RESOLVED WONTFIX

(Firefox :: Theme, enhancement)

Description

[Johann Hofmann [:johannh]]

menuPanel.svg is one of the last remaining places where we use filters.svg#fill, which isn't great for performance. We should use context-fill instead.

Comment 1

[:Gijs (he/him)]

menuPanel.svg is going to go away with photon structure because the old panel menu will be dead. Is this really worth pursuing at this stage, just for 56?

Comment 2

[Johann Hofmann [:johannh]]

Right, I didn't realize that. It's not worth it, then. Thanks!

Comment 3

[Jonathan Watt [:jwatt]]

(In reply to :Gijs from comment #1)
> menuPanel.svg is going to go away with photon structure because the old
> panel menu will be dead. Is this really worth pursuing at this stage, just
> for 56?

Is there a way of tracking this? Ideally a bug that we can mark as blocking bug 1358998 so that we are notified when that bug can be closed and the filter removed from filters.svg.

Comment 4

[Jonathan Watt [:jwatt]]

I mean bug 1359073.

Comment 5

[:Gijs (he/him)]

(In reply to Jonathan Watt [:jwatt] from comment #3)
> (In reply to :Gijs from comment #1)
> > menuPanel.svg is going to go away with photon structure because the old
> > panel menu will be dead. Is this really worth pursuing at this stage, just
> > for 56?
> 
> Is there a way of tracking this? Ideally a bug that we can mark as blocking
> bug 1358998 so that we are notified when that bug can be closed and the
> filter removed from filters.svg.

I don't think we've filed explicit bugs on "remove everything obsoleted by photon" yet. Feel free to file bugs as you think is appropriate. It should probably depend on bug 1354086 being fixed, because I think right now buttons might still be using these icons in the permanent part of the overflow panel in photon (which should be fixed in that bug).