1373116 - Intermittent browser/components/sessionstore/test/browser_windowStateContainer.js | application crashed [@ RunWatchdog]

Status: RESOLVED INCOMPLETE

(Firefox :: Session Restore, defect)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=107187587&repo=autoland

https://queue.taskcluster.net/v1/task/dywoNPfeQWGJmEjL2-K4fw/runs/0/artifacts/public/logs/live_backing.log

In general, a RunWatchdog failure in CI is pretty much meaningless, since despite being blamed on a particular test that test is just the last test which ran during the browser session, and the problem RunWatchdog is proclaiming, "shutdown took longer than I wanted it to take" could have been caused by any test in the run, not just that one.

However, this is failing constantly (one set of retriggers I saw it failed 9 out of 10 runs), and in browser-chrome we start and stop the browser for every directory of tests, so this failure is actually "one of the tests in browser/components/sessionstore/test/ causes shutdown on Linux32 to take too long."

Comment 1

[Intermittent Failures Robot]

25 failures in 131 pushes (0.191 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* autoland: 11
* mozilla-inbound: 9
* mozilla-central: 4
* try: 1

Platform breakdown:
* linux32: 25

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1373116&startday=2017-06-15&endday=2017-06-15&tree=all

Comment 2

[Intermittent Failures Robot]

30 failures in 147 pushes (0.204 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* mozilla-inbound: 14
* autoland: 13
* mozilla-central: 3

Platform breakdown:
* linux32: 30

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1373116&startday=2017-06-16&endday=2017-06-16&tree=all

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

67 failures since June 14th, this is on track to be one of our top intermittents.  I see a fix in bug 1358898, I assume this will be fixed by then.

Comment 4

[Intermittent Failures Robot]

74 failures in 814 pushes (0.091 failures/push) were associated with this bug in the last 7 days. 

This is the #24 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* autoland: 36
* mozilla-inbound: 26
* mozilla-central: 11
* try: 1

Platform breakdown:
* linux32: 74

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1373116&startday=2017-06-12&endday=2017-06-18&tree=all

Comment 5

[Carsten Book [:Tomcat]]

(In reply to Joel Maher ( :jmaher) from comment #3)
> 67 failures since June 14th, this is on track to be one of our top
> intermittents.  I see a fix in bug 1358898, I assume this will be fixed by
> then.

indeed this is nearly perma failing now

Comment 6

[Joel Maher ( :jmaher ) (UTC -8)]

this is still failing and bug bug 1358898 didn't change anything.

:mike, I see you are the triage owner for sessionrestore, can you help find someone on the sessionrestore team to look at this very frequent intermittent failure and help get a resolution (fix, reduced, disabled) by the end of  the week?

Comment 7

[Intermittent Failures Robot]

42 failures in 151 pushes (0.278 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* mozilla-inbound: 18
* autoland: 18
* try: 4
* mozilla-central: 2

Platform breakdown:
* linux32: 42

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1373116&startday=2017-06-19&endday=2017-06-19&tree=all

Comment 8

[Intermittent Failures Robot]

28 failures in 173 pushes (0.162 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* mozilla-inbound: 12
* try: 8
* autoland: 6
* mozilla-central: 2

Platform breakdown:
* linux32: 27
* windows7-32-vm: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1373116&startday=2017-06-20&endday=2017-06-20&tree=all

Comment 9

[Mike de Boer [:mikedeboer]]

Yoshi wrote the test and is basically the owner for it - perhaps he knows what might be going on?
But I think a good first move is the just disable this test on linux. The failure rate is just insane atm.

Comment 10

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1373116 - Disable browser_windowStateContainer.js mochitest on Linux until it is fixed.

Review commit: https://reviewboard.mozilla.org/r/151312/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151312/

Comment 11

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 8879908 [details]
Bug 1373116 - Disable browser_windowStateContainer.js mochitest on Linux until it is fixed.

https://reviewboard.mozilla.org/r/151312/#review156198

you might want to consider doing this on opt only:
skip-if = os == "linux" && !debug

that would get us some coverage on linux :)

Comment 12

[Mike de Boer [:mikedeboer]]

Comment on attachment 8879908 [details]
Bug 1373116 - Disable browser_windowStateContainer.js mochitest on Linux until it is fixed.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/151312/diff/1-2/

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a541b46cb8ff
Disable browser_windowStateContainer.js mochitest on Linux until it is fixed. r=jmaher

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/a541b46cb8ff

Comment 15

[Geoff Brown [:gbrown]]

This was a shutdown crash, not necessarily associated with browser_windowStateContainer.js:

https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=108679869&lineNumber=3058

[task 2017-06-20T22:44:54.796192Z] 22:44:54     INFO - TEST-OK | browser/components/sessionstore/test/browser_windowStateContainer.js | took 8460ms
[task 2017-06-20T22:44:54.943256Z] 22:44:54     INFO - checking window state
[task 2017-06-20T22:45:06.298058Z] 22:45:06     INFO - GECKO(1577) | Completed ShutdownLeaks collections in process 1577
[task 2017-06-20T22:45:06.300415Z] 22:45:06     INFO - TEST-START | Shutdown
[task 2017-06-20T22:45:06.301639Z] 22:45:06     INFO - Browser Chrome Test Summary
[task 2017-06-20T22:45:06.304550Z] 22:45:06     INFO - Passed:  1174
[task 2017-06-20T22:45:06.306482Z] 22:45:06     INFO - Failed:  0
[task 2017-06-20T22:45:06.308723Z] 22:45:06     INFO - Todo:    0
[task 2017-06-20T22:45:06.311256Z] 22:45:06     INFO - Mode:    non-e10s
[task 2017-06-20T22:45:06.319324Z] 22:45:06     INFO - *** End BrowserChrome Test Results ***
[task 2017-06-20T22:46:11.689491Z] 22:46:11     INFO - GECKO(1577) | ExceptionHandler::GenerateDump cloned child 1666
[task 2017-06-20T22:46:11.692337Z] 22:46:11     INFO - GECKO(1577) | ExceptionHandler::SendContinueSignalToChild sent continue signal to child
[task 2017-06-20T22:46:11.694488Z] 22:46:11     INFO - GECKO(1577) | ExceptionHandler::WaitForContinueSignal waiting for continue signal...
[task 2017-06-20T22:46:12.376110Z] 22:46:12     INFO - TEST-INFO | Main app process: exit 11
[task 2017-06-20T22:46:12.378619Z] 22:46:12     INFO - Buffered messages finished
[task 2017-06-20T22:46:12.380479Z] 22:46:12    ERROR - TEST-UNEXPECTED-FAIL | browser/components/sessionstore/test/browser_windowStateContainer.js | application terminated with exit code 11


browser_windowStateContainer.js was just the last test to run in that job. Disabling the test moved the crash to bug 1244904.

Comment 16

[Intermittent Failures Robot]

83 failures in 892 pushes (0.093 failures/push) were associated with this bug in the last 7 days. 

This is the #20 most frequent failure this week. 

** This failure happened more than 75 times this week! Resolving this bug is a very high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 1 week, the affected test(s) may be disabled. **  

Repository breakdown:
* mozilla-inbound: 31
* autoland: 25
* try: 21
* mozilla-central: 6

Platform breakdown:
* linux32: 82
* windows7-32-vm: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1373116&startday=2017-06-19&endday=2017-06-25&tree=all

Comment 17

[Intermittent Failures Robot]

3 failures in 718 pushes (0.004 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* try: 3

Platform breakdown:
* linux32: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1373116&startday=2017-06-26&endday=2017-07-02&tree=all

Comment 18

[Intermittent Failures Robot]

8 failures in 656 pushes (0.012 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* try: 8

Platform breakdown:
* linux32: 8

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1373116&startday=2017-07-03&endday=2017-07-09&tree=all

Comment 19

[Intermittent Failures Robot]

21 failures in 720 pushes (0.029 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* try: 18
* oak: 3

Platform breakdown:
* linux32: 21

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1373116&startday=2017-07-10&endday=2017-07-16&tree=all

Comment 20

[Intermittent Failures Robot]

3 failures in 1008 pushes (0.003 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* try: 3

Platform breakdown:
* linux32: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1373116&startday=2017-07-24&endday=2017-07-30&tree=all

Comment 21

[Intermittent Failures Robot]

1 failures in 864 pushes (0.001 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* autoland: 1

Platform breakdown:
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1373116&startday=2017-10-16&endday=2017-10-22&tree=all

Comment 22

[Intermittent Failures Robot]

1 failures in 849 pushes (0.001 failures/push) were associated with this bug in the last 7 days.    

Repository breakdown:
* mozilla-release: 1

Platform breakdown:
* windows10-64-stylo-disabled: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1373116&startday=2017-11-06&endday=2017-11-12&tree=all

Comment 23

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.