Permared build bustage on Windows debug when Gecko 56 merges to beta on 2017-08-07

RESOLVED FIXED in Firefox 56

Status

()

Core
Graphics: WebRender
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: philor, Assigned: nical)

Tracking

56 Branch
mozilla56
Points:
---

Firefox Tracking Flags

(firefox-esr45 unaffected, firefox-esr52 unaffected, firefox54 unaffected, firefox55 unaffected, firefox56+ fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

a year ago
MSVC is not happy with bug 1370879 as it will be compiled on beta when mozilla-central merges there in August.

https://treeherder.mozilla.org/logviewer.html#?job_id=107183228&repo=try

19:31:18     INFO -  c:\builds\moz2_slave\try-w32-d-00000000000000000000\build\src\gfx\webrender_bindings\renderthread.cpp(336) : error C2220: warning treated as error - no 'object' file generated
19:31:18     INFO -  c:\builds\moz2_slave\try-w32-d-00000000000000000000\build\src\gfx\webrender_bindings\renderthread.cpp(336) : warning C4722: 'mozilla::wr::WebRenderThreadPool::~WebRenderThreadPool': destructor never returns, potential memory leak
19:31:18     INFO -  c:\builds\moz2_slave\try-w32-d-00000000000000000000\build\src\gfx\webrender_bindings\renderthread.cpp(33) : warning C4722: 'mozilla::wr::RenderThread::~RenderThread': destructor never returns, potential memory leak

[Tracking Requested - why for this release]: if it's not fixed, merge build bustage, closed tree, delayed b1.
(Reporter)

Updated

a year ago
Flags: needinfo?(nical.bugzilla)
(Assignee)

Comment 1

a year ago
Created attachment 8877950 [details] [diff] [review]
Make wr_thread_pool_delete dtor-safe.

This should fix the build on branches that don't build webrender.
Assignee: nobody → nical.bugzilla
Flags: needinfo?(nical.bugzilla)
Attachment #8877950 - Flags: review?(bugmail)
Attachment #8877950 - Flags: review?(bugmail) → review+
Blocks: 1370879
Version: 55 Branch → 56 Branch

Comment 2

a year ago
Pushed by nsilva@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/79fbc260febf
Mark wr_thread_pool_delete destructor-safe. r=kats
https://hg.mozilla.org/mozilla-central/rev/79fbc260febf
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
tracking-firefox56: ? → +
You need to log in before you can comment on or make changes to this bug.