Closed Bug 1373139 Opened 7 years ago Closed 7 years ago

Intermittent browser/components/resistfingerprinting/test/browser/browser_roundedWindow_open_mid.js | This test exceeded the timeout threshold. It should be rewritten or split up. If that's not possible, use requestLongerTimeout(N)

Categories

(Core :: Security, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla58
Tracking Status
firefox58 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: cfu)

References

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

Ethan: can someone on your team look into making this test more reliable?
Flags: needinfo?(ettseng)
Priority: -- → P3
Assignee: nobody → tihuang
Flags: needinfo?(ettseng)
Tim knows the root cause.
He just needs to figure out an ideal solution.
Assignee: tihuang → cfu
Depends on: 1406294
Attachment #8918712 - Flags: review?(tihuang)
Attachment #8918712 - Flags: review?(bugs)
Number of opened windows: 8 -> 5, saving up to 37.5% of execution time.
Comment on attachment 8918712 [details]
Bug 1373139 - Split browser/components/resistfingerprinting/test/browser/browser_roundedWindow_open_mid.js.

https://reviewboard.mozilla.org/r/189522/#review195060

(MozReview is so broken when reviewing patches which remove files. I guess you could have renamed the file and add the boolean param, and then copy the file and change the boolean param. oh well, this is testing only, so fine)
Attachment #8918712 - Flags: review?(bugs) → review+
Comment on attachment 8918712 [details]
Bug 1373139 - Split browser/components/resistfingerprinting/test/browser/browser_roundedWindow_open_mid.js.

https://reviewboard.mozilla.org/r/189522/#review195218
Attachment #8918712 - Flags: review?(tihuang) → review+
Keywords: checkin-needed
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 4b99359e45ab -d 9edd3c8a941d: rebasing 427008:4b99359e45ab "Bug 1373139 - Split browser/components/resistfingerprinting/test/browser/browser_roundedWindow_open_mid.js. r=smaug,timhuang" (tip)
merging browser/components/resistfingerprinting/test/browser/browser.ini
warning: conflicts while merging browser/components/resistfingerprinting/test/browser/browser.ini! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.

hg error in cmd: hg rebase -s 4b99359e45ab -d 334fad658d2c: rebasing 427008:4b99359e45ab "Bug 1373139 - Split browser/components/resistfingerprinting/test/browser/browser_roundedWindow_open_mid.js. r=smaug,timhuang"
merging browser/components/resistfingerprinting/test/browser/browser.ini
warning: conflicts while merging browser/components/resistfingerprinting/test/browser/browser.ini! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Needs rebasing.
Flags: needinfo?(cfu)
Keywords: checkin-needed
Flags: needinfo?(cfu)
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/43e31e001721
Split browser/components/resistfingerprinting/test/browser/browser_roundedWindow_open_mid.js. r=smaug,timhuang
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/43e31e001721
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla58
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: