1373143 - Fix lint: NewApi issues in WebRtcAudioTrack.java

Status: RESOLVED INCOMPLETE

(Firefox for Android Graveyard :: General, enhancement, P3)

Description

[Kilik Kuo [:kikuo] (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=b418d94f024c&selectedJob=107201915

 ../../../../../../../media/webrtc/trunk/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java:137: Call requires API level 21 (current min is 15): android.media.AudioTrack#write

 134     }
 135 
 136     private int writeOnLollipop(AudioTrack audioTrack, ByteBuffer byteBuffer, int sizeInBytes) {
 137       return audioTrack.write(byteBuffer, sizeInBytes, AudioTrack.WRITE_BLOCKING);
 138     }
 139 

../../../../../../../media/webrtc/trunk/webrtc/modules/audio_device/android/java/src/org/webrtc/voiceengine/WebRtcAudioTrack.java:294: Call requires API level 23 (current min is 15): android.media.AudioTrack#getBufferSizeInFrames

 291     if (WebRtcAudioUtils.runningOnMarshmallowOrHigher()) {
 292       Log.d(TAG, "AudioTrack: "
 293               // The effective size of the AudioTrack buffer that the app writes to.
 294               + "buffer size in frames: " + audioTrack.getBufferSizeInFrames());
 295     }
 296 /* Mozilla: This requires API Level 24, but we build for 23

Comment 1

[Teng-pao Yu [:tyu]]

Thanks for helping on fixing the lint errors!

I noticed this too, but did not file a bug since seems like someone is already taking a look yesterday on Bug 1341285.

I just visited the bug and seems like this will be fixed soon.

Comment 2

[BMO Automation]

We have completed our launch of our new Firefox on Android. The development of the new versions use GitHub for issue tracking. If the bug report still reproduces in a current version of [Firefox on Android nightly](https://play.google.com/store/apps/details?id=org.mozilla.fenix) an issue can be reported at the [Fenix GitHub project](https://github.com/mozilla-mobile/fenix/). If you want to discuss your report please use [Mozilla's chat](https://wiki.mozilla.org/Matrix#Connect_to_Matrix) server https://chat.mozilla.org and join the [#fenix](https://chat.mozilla.org/#/room/#fenix:mozilla.org) channel.