1373170 - Intermittent mobile/android/components/extensions/test/mochitest/test_ext_pageAction_getPopup_setPopup.html | The popup with the correct URL should be shown.

Status: RESOLVED FIXED

(WebExtensions :: Android, defect, P3)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://treeherder.mozilla.org/logviewer.html#?job_id=107209035&repo=autoland

[task 2017-06-15T04:28:21.836390Z] 04:28:21     INFO -  100 INFO TEST-PASS | mobile/android/components/extensions/test/mochitest/test_ext_pageAction_getPopup_setPopup.html | Expected the correct popup for tab 4
[task 2017-06-15T04:28:21.836858Z] 04:28:21     INFO -  101 INFO TEST-PASS | mobile/android/components/extensions/test/mochitest/test_ext_pageAction_getPopup_setPopup.html | page action is shown
[task 2017-06-15T04:28:21.837647Z] 04:28:21     INFO -  Buffered messages logged at 04:28:05
[task 2017-06-15T04:28:21.838333Z] 04:28:21     INFO -  102 INFO TEST-PASS | mobile/android/components/extensions/test/mochitest/test_ext_pageAction_getPopup_setPopup.html | The popup with the correct URL should be shown.
[task 2017-06-15T04:28:21.838751Z] 04:28:21     INFO -  Buffered messages logged at 04:28:06
[task 2017-06-15T04:28:21.840220Z] 04:28:21     INFO -  103 INFO TEST-PASS | mobile/android/components/extensions/test/mochitest/test_ext_pageAction_getPopup_setPopup.html | The popup with the correct URL should be closed.
[task 2017-06-15T04:28:21.840903Z] 04:28:21     INFO -  104 INFO TEST-PASS | mobile/android/components/extensions/test/mochitest/test_ext_pageAction_getPopup_setPopup.html | Expected the correct popup for tab 5
[task 2017-06-15T04:28:21.841403Z] 04:28:21     INFO -  105 INFO TEST-PASS | mobile/android/components/extensions/test/mochitest/test_ext_pageAction_getPopup_setPopup.html | page action is shown
[task 2017-06-15T04:28:21.841625Z] 04:28:21     INFO -  Buffered messages finished
[task 2017-06-15T04:28:21.842167Z] 04:28:21     INFO -  106 INFO TEST-UNEXPECTED-FAIL | mobile/android/components/extensions/test/mochitest/test_ext_pageAction_getPopup_setPopup.html | The popup with the correct URL should be shown.
[task 2017-06-15T04:28:21.842756Z] 04:28:21     INFO -  testPopup@chrome://mochitests/content/chrome/mobile/android/components/extensions/test/mochitest/test_ext_pageAction_getPopup_setPopup.html:178:5
[task 2017-06-15T04:28:21.843510Z] 04:28:21     INFO -  107 INFO TEST-UNEXPECTED-FAIL | mobile/android/components/extensions/test/mochitest/test_ext_pageAction_getPopup_setPopup.html | The popup with the correct URL should be closed.
[task 2017-06-15T04:28:21.844032Z] 04:28:21     INFO -  testPopup@chrome://mochitests/content/chrome/mobile/android/components/extensions/test/mochitest/test_ext_pageAction_getPopup_setPopup.html:182:5

Comment 1

[Intermittent Failures Robot]

22 failures in 814 pushes (0.027 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* mozilla-inbound: 12
* autoland: 8
* mozilla-central: 2

Platform breakdown:
* android-api-15-gradle: 18
* android-4-3-armv7-api15: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1373170&startday=2017-06-12&endday=2017-06-18&tree=all

Comment 2

[Geoff Brown [:gbrown]]

This failure started shortly after the test was updated in bug 1300811.

Comment 3

[Intermittent Failures Robot]

49 failures in 892 pushes (0.055 failures/push) were associated with this bug in the last 7 days. 

This is the #39 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* autoland: 27
* mozilla-inbound: 22

Platform breakdown:
* android-api-15-gradle: 36
* android-4-3-armv7-api15: 11
* android-4-2-x86: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1373170&startday=2017-06-19&endday=2017-06-25&tree=all

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/96c0145be026
Skip test test_ext_pageAction_getPopup_setPopup.html on Android, for frequent intermittent failures; r=me,test-only

Comment 5

[Intermittent Failures Robot]

23 failures in 193 pushes (0.119 failures/push) were associated with this bug yesterday.   

Repository breakdown:
* autoland: 17
* mozilla-inbound: 4
* try: 2

Platform breakdown:
* android-api-15-gradle: 19
* android-4-3-armv7-api15: 4

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1373170&startday=2017-06-29&endday=2017-06-29&tree=all

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/96c0145be026

Comment 7

[Intermittent Failures Robot]

61 failures in 718 pushes (0.085 failures/push) were associated with this bug in the last 7 days. 

This is the #19 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* autoland: 37
* mozilla-inbound: 12
* try: 6
* mozilla-central: 6

Platform breakdown:
* android-api-15-gradle: 38
* android-4-3-armv7-api15: 20
* android-4-2-x86: 3

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1373170&startday=2017-06-26&endday=2017-07-02&tree=all

Comment 8

[Bob Silverberg [:bsilverberg]]

This test is only failing on Android, but it's an Android-only test, so I think we should endeavour to re-enable it if we can, as it's not getting other coverage. There was also a suggestion, in comment #2, that the test started failing after some code landed, so it seems worth investigating. Luca, do you think you could find time to take a look at this?

Comment 9

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1373170 - Closing the extension popup tab should select the parent tab only if the popup tab was selected.

Review commit: https://reviewboard.mozilla.org/r/195800/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/195800/

Comment 10

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1373170 - Fix and re-enable android pageAction getPopup/setPopup tests.

Review commit: https://reviewboard.mozilla.org/r/195802/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/195802/

Comment 11

[Luca Greco [:rpl] [:luca] [:lgreco]]

I took a look at this intermittent and I've been able to see it in action locally by running the mochitest on an android-x86 emulator.

While investigating the failure I also caught an issue introduced in Bug 1383160, which was also introduced an additional intermittent failure in this test (less frequent of the initial one, but still reproducible by running the test an higher number of times using ./mach mochitest --repeat).

I'm going to push these two patches on try from mozreview to verify if they are still intermittent on the infrastructure.

Comment 12

[Luca Greco [:rpl] [:luca] [:lgreco]]

Some notes about the issue that is likely to be the one that has introduced the intermittent failure (Bug 1383160 has been landed after this test has been disabled and so it is not related to the initial intermittent):

- selecting a tab happens asynchronously: the privileged JS code sends a message to the Firefox for Android Java code and the Java code will message back to the privileged JS code once the request has been processed

- intermittently, when PageActions.synthesizeClick has been called in the test, the currently selected tab was different from the one where the pageAction has been shown and the test waits indefinitely the popup to be opened and timeouts

Comment 13

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 8924541 [details]
Bug 1373170 - Closing the extension popup tab should select the parent tab only if the popup tab was selected.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/195800/diff/1-2/

Comment 14

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 8924542 [details]
Bug 1373170 - Fix and re-enable android pageAction getPopup/setPopup tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/195802/diff/1-2/

Comment 15

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 8924542 [details]
Bug 1373170 - Fix and re-enable android pageAction getPopup/setPopup tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/195802/diff/2-3/

Comment 16

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8924542 [details]
Bug 1373170 - Fix and re-enable android pageAction getPopup/setPopup tests.

https://reviewboard.mozilla.org/r/195802/#review204520

The changes to the test look good and make sense to me.

Comment 17

[Luca Greco [:rpl] [:luca] [:lgreco]]

Comment on attachment 8924542 [details]
Bug 1373170 - Fix and re-enable android pageAction getPopup/setPopup tests.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/195802/diff/3-4/

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3e99c259e2dc
Fix and re-enable android pageAction getPopup/setPopup tests. r=bsilverberg

Comment 19

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/3e99c259e2dc

Comment 20

[Bob Silverberg [:bsilverberg]]

This was re-enabled 3 months ago.

Comment 21

[Firefox Bug Husbandry Bot]

Removing leave-open keyword from resolved bugs, per :sylvestre.