Closed Bug 1373170 Opened 3 years ago Closed 2 years ago

Intermittent mobile/android/components/extensions/test/mochitest/test_ext_pageAction_getPopup_setPopup.html | The popup with the correct URL should be shown.

Categories

(WebExtensions :: Android, defect, P3)

defect

Tracking

(firefox57 wontfix)

RESOLVED FIXED
Tracking Status
firefox57 --- wontfix

People

(Reporter: aryx, Assigned: rpl)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed])

Attachments

(1 file, 1 obsolete file)

https://treeherder.mozilla.org/logviewer.html#?job_id=107209035&repo=autoland

[task 2017-06-15T04:28:21.836390Z] 04:28:21     INFO -  100 INFO TEST-PASS | mobile/android/components/extensions/test/mochitest/test_ext_pageAction_getPopup_setPopup.html | Expected the correct popup for tab 4
[task 2017-06-15T04:28:21.836858Z] 04:28:21     INFO -  101 INFO TEST-PASS | mobile/android/components/extensions/test/mochitest/test_ext_pageAction_getPopup_setPopup.html | page action is shown
[task 2017-06-15T04:28:21.837647Z] 04:28:21     INFO -  Buffered messages logged at 04:28:05
[task 2017-06-15T04:28:21.838333Z] 04:28:21     INFO -  102 INFO TEST-PASS | mobile/android/components/extensions/test/mochitest/test_ext_pageAction_getPopup_setPopup.html | The popup with the correct URL should be shown.
[task 2017-06-15T04:28:21.838751Z] 04:28:21     INFO -  Buffered messages logged at 04:28:06
[task 2017-06-15T04:28:21.840220Z] 04:28:21     INFO -  103 INFO TEST-PASS | mobile/android/components/extensions/test/mochitest/test_ext_pageAction_getPopup_setPopup.html | The popup with the correct URL should be closed.
[task 2017-06-15T04:28:21.840903Z] 04:28:21     INFO -  104 INFO TEST-PASS | mobile/android/components/extensions/test/mochitest/test_ext_pageAction_getPopup_setPopup.html | Expected the correct popup for tab 5
[task 2017-06-15T04:28:21.841403Z] 04:28:21     INFO -  105 INFO TEST-PASS | mobile/android/components/extensions/test/mochitest/test_ext_pageAction_getPopup_setPopup.html | page action is shown
[task 2017-06-15T04:28:21.841625Z] 04:28:21     INFO -  Buffered messages finished
[task 2017-06-15T04:28:21.842167Z] 04:28:21     INFO -  106 INFO TEST-UNEXPECTED-FAIL | mobile/android/components/extensions/test/mochitest/test_ext_pageAction_getPopup_setPopup.html | The popup with the correct URL should be shown.
[task 2017-06-15T04:28:21.842756Z] 04:28:21     INFO -  testPopup@chrome://mochitests/content/chrome/mobile/android/components/extensions/test/mochitest/test_ext_pageAction_getPopup_setPopup.html:178:5
[task 2017-06-15T04:28:21.843510Z] 04:28:21     INFO -  107 INFO TEST-UNEXPECTED-FAIL | mobile/android/components/extensions/test/mochitest/test_ext_pageAction_getPopup_setPopup.html | The popup with the correct URL should be closed.
[task 2017-06-15T04:28:21.844032Z] 04:28:21     INFO -  testPopup@chrome://mochitests/content/chrome/mobile/android/components/extensions/test/mochitest/test_ext_pageAction_getPopup_setPopup.html:182:5
Component: WebExtensions: Untriaged → WebExtensions: Android
Whiteboard: [stockwell needswork]
This failure started shortly after the test was updated in bug 1300811.
Blocks: 1300811
Flags: needinfo?(mwein)
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/96c0145be026
Skip test test_ext_pageAction_getPopup_setPopup.html on Android, for frequent intermittent failures; r=me,test-only
Keywords: leave-open
Whiteboard: [stockwell needswork] → [stockwell disabled]
Flags: needinfo?(matthewjwein)
Priority: -- → P5
This test is only failing on Android, but it's an Android-only test, so I think we should endeavour to re-enable it if we can, as it's not getting other coverage. There was also a suggestion, in comment #2, that the test started failing after some code landed, so it seems worth investigating. Luca, do you think you could find time to take a look at this?
Flags: needinfo?(lgreco)
Priority: P5 → P3
I took a look at this intermittent and I've been able to see it in action locally by running the mochitest on an android-x86 emulator.

While investigating the failure I also caught an issue introduced in Bug 1383160, which was also introduced an additional intermittent failure in this test (less frequent of the initial one, but still reproducible by running the test an higher number of times using ./mach mochitest --repeat).

I'm going to push these two patches on try from mozreview to verify if they are still intermittent on the infrastructure.
Flags: needinfo?(lgreco)
Some notes about the issue that is likely to be the one that has introduced the intermittent failure (Bug 1383160 has been landed after this test has been disabled and so it is not related to the initial intermittent):

- selecting a tab happens asynchronously: the privileged JS code sends a message to the Firefox for Android Java code and the Java code will message back to the privileged JS code once the request has been processed

- intermittently, when PageActions.synthesizeClick has been called in the test, the currently selected tab was different from the one where the pageAction has been shown and the test waits indefinitely the popup to be opened and timeouts
Attachment #8924541 - Attachment is obsolete: true
Depends on: 1414379
Attachment #8924542 - Flags: review?(bob.silverberg)
Comment on attachment 8924542 [details]
Bug 1373170 - Fix and re-enable android pageAction getPopup/setPopup tests.

https://reviewboard.mozilla.org/r/195802/#review204520

The changes to the test look good and make sense to me.
Attachment #8924542 - Flags: review?(bob.silverberg) → review+
Assignee: nobody → lgreco
Status: NEW → ASSIGNED
Pushed by luca.greco@alcacoop.it:
https://hg.mozilla.org/integration/autoland/rev/3e99c259e2dc
Fix and re-enable android pageAction getPopup/setPopup tests. r=bsilverberg
This was re-enabled 3 months ago.
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Whiteboard: [stockwell disabled] → [stockwell fixed]
Removing leave-open keyword from resolved bugs, per :sylvestre.
Keywords: leave-open
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.