1373188 - Remove the redundant css toggling and update to the right css rule in browser_onboarding_hide_tours.js

Status: RESOLVED INVALID

(Firefox :: General, enhancement)

Description

[Fischer [:Fischer]]

This is a follow-up bug of the bug 1357020. Because of the miss during rebasing patch, we are toggling a redundant "opened" css selector and testing based on that redundant css selector.

Comment 1

[Fischer [:Fischer]]

Attachment: Bug 1373188 - Remove the redundant css toggling and update to the right css rule in browser_onboarding_hide_tours.js,

Review commit: https://reviewboard.mozilla.org/r/149418/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/149418/

Comment 2

[Fischer [:Fischer]]

(In reply to Fischer [:Fischer] from comment #1)
> Created attachment 8878010 [details]
> Bug 1373188 - Remove the redundant css toggling and update to the right css
> rule in browser_onboarding_hide_tours.js,
> 
> Review commit: https://reviewboard.mozilla.org/r/149418/diff/#index_header
> See other reviews: https://reviewboard.mozilla.org/r/149418/
Hi Rex,
TRY: https://treeherder.mozilla.org/#/jobs?repo=try&revision=2dbb9e2fb9735bb908328441bc3e0f9703de131a
Thank you

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Comment on attachment 8878010 [details]
Bug 1373188 - Remove the redundant css toggling and update to the right css rule in browser_onboarding_hide_tours.js,

https://reviewboard.mozilla.org/r/149418/#review154334

Thanks for finding it out. We had a lot of rebases these days. :-/
Looks good to me.

Comment 4

[Fischer [:Fischer]]

Comment on attachment 8878010 [details]
Bug 1373188 - Remove the redundant css toggling and update to the right css rule in browser_onboarding_hide_tours.js,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/149418/diff/1-2/

Comment 5

[Fischer [:Fischer]]

(In reply to Fischer [:Fischer] from comment #4)
> Comment on attachment 8878010 [details]
> Bug 1373188 - Remove the redundant css toggling and update to the right css
> rule in browser_onboarding_hide_tours.js,
> 
> Review request updated; see interdiff:
> https://reviewboard.mozilla.org/r/149418/diff/1-2/
TRY: https://treeherder.mozilla.org/#/jobs?repo=try&revision=38a4b5a3d58638374b53e49a3918dfe78e33e791

Comment 6

[Fischer [:Fischer]]

Comment on attachment 8878010 [details]
Bug 1373188 - Remove the redundant css toggling and update to the right css rule in browser_onboarding_hide_tours.js,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/149418/diff/2-3/

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Autoland can't push this until it's showing as r+ from a valid reviewer in MozReview.
http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/autoland.html#landing-commits

Comment 8

[Fischer [:Fischer]]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #7)
> Autoland can't push this until it's showing as r+ from a valid reviewer in
> MozReview.
> http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/autoland.html#landing-commits
Hi Byron,

We could see the r+ in the reviewers column and the bugzilla but still r? status in the commit column [1].
Saw you fix some MozReview status issue in Bug 1357046 comment 87.
Would you help this out here, thank you.

[1] https://reviewboard.mozilla.org/r/149416/

Comment 9

[:glob ✱]

(In reply to Fischer [:Fischer] from comment #8)
> We could see the r+ in the reviewers column and the bugzilla but still r?
> status in the commit column [1].

a patch needs approval from a reviewer with commit level 3 before it can be landed with autoland.
as far as i can tell :rexboy does not have level 3.

Comment 10

[Fischer [:Fischer]]

Mark as INVALID because other patch has rebased the code correctly.