1373213 - Repair cubeb logging

Status: RESOLVED FIXED

(Core :: Audio/Video: cubeb, enhancement, P1)

Comment 1

[Paul Adenot (:padenot)]

When enabling logging via MOZ_LOG env var, it does not work. It goes like this:
- On startup, the env var are read, logging for cubeb is enabled
- We specify a pref in all.js, that is, by default, set to "" (empty string)
- We have a RegisterCallbackAndCall in CubebUtils::Init, that ended up calling the PrefChanged function, that ended up setting the log module to "disabled".

There is a member in LogModuleManager that can tell us whether log modules have been set via an env var, but it's not exposed. Enabling a log module via pref is nice, but mostly useful during execution, not at startup. In addition, because cubeb is an external library, it can't use MOZ_LOG, and so needs to enable/disable logging by hand.

Removing the pref from all.js and not calling the PrefChanged function on startup repairs it so we can diagnose stuff. Ideally, we would expose this member from LogModuleManager so we could distinguish from MOZ_LOG and prefs, when it come to log modules activation. We can do that later.

Comment 2

[Paul Adenot (:padenot)]

Attachment: Bug 1373213 - Repair cubeb logging when using env var.

Review commit: https://reviewboard.mozilla.org/r/149414/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/149414/

Comment 3

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8878002 [details]
Bug 1373213 - Repair cubeb logging when using env var.

https://reviewboard.mozilla.org/r/149414/#review154020

Comment 4

[Paul Adenot (:padenot)]

Hrm, I suppose that this won't work too well because the pref is still in the user profile. I'll get something better.

Comment 5

[Paul Adenot (:padenot)]

Comment on attachment 8878002 [details]
Bug 1373213 - Repair cubeb logging when using env var.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/149414/diff/1-2/

Comment 6

[Paul Adenot (:padenot)]

Comment on attachment 8878002 [details]
Bug 1373213 - Repair cubeb logging when using env var.

https://reviewboard.mozilla.org/r/149414/#review157384

Comment 7

[Paul Adenot (:padenot)]

review ping, this is blocking a bunch of stuff

Comment 8

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8878002 [details]
Bug 1373213 - Repair cubeb logging when using env var.

https://reviewboard.mozilla.org/r/149414/#review163138

Comment 9

[Randell Jesup [:jesup] (needinfo me)]

It was already r+ in mozreview.... no idea why it wasn't here.  Published again, fixed it

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e2eff4d5dd0
Repair cubeb logging when using env var. r=jesup

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/8e2eff4d5dd0