Closed
Bug 1373267
Opened 7 years ago
Closed 7 years ago
Remove hashFunction and hashValue attributes from nsIUpdatePatch and code related to these values
Categories
(Toolkit :: Application Update, enhancement)
Toolkit
Application Update
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: robert.strong.bugs, Assigned: robert.strong.bugs)
References
Details
Attachments
(1 file, 1 obsolete file)
|
30.55 KB,
patch
|
molly
:
review+
|
Details | Diff | Splinter Review |
These attributes haven't been used for quite some time and instead we rely on mar signing. Also, in bug 1343891 these values will be removed from the xml served to app update.
|
||
Comment 1•7 years ago
|
||
I don't think TB relies on mar signing.
|
Assignee | |
Comment 2•7 years ago
|
||
I know but it is now going on a couple of years to add it. bug 1189843
|
|
Assignee | |
Comment 3•7 years ago
|
||
iirc Thunderbird does check he mar signature on Windows since they wanted to take advantage of the maintenance service and this appears to be the case
https://dxr.mozilla.org/comm-central/source/mail/confvars.sh#21
|
|
Assignee | |
Comment 4•7 years ago
|
||
Assignee: nobody → robert.strong.bugs
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•7 years ago
|
Target Milestone: --- → mozilla56
|
|
Assignee | |
Comment 5•7 years ago
|
||
Pushed to try
https://treeherder.mozilla.org/#/jobs?repo=try&revision=077b32be5d3dad72be5023da9ba049193a279d57
Attachment #8878125 -
Attachment is obsolete: true
|
|
Assignee | |
Comment 6•7 years ago
|
||
Henrik, just a heads up though I don't think these changes will affect your tests.
Flags: needinfo?(hskupin)
|
|
Assignee | |
Comment 7•7 years ago
|
||
Comment on attachment 8878129 [details] [diff] [review]
patch rev1
So much easier to update the tests now. :)
Attachment #8878129 -
Flags: review?(mhowell)
|
||
Comment 8•7 years ago
|
||
(In reply to Robert Strong [:rstrong] (use needinfo to contact me) from comment #6)
> Henrik, just a heads up though I don't think these changes will affect your
> tests.
No, those are not in use.
Flags: needinfo?(hskupin)
|
||
Updated•7 years ago
|
Attachment #8878129 -
Flags: review?(mhowell) → review+
Pushed by rstrong@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e886bf1ba8fc
Remove hashFunction and hashValue attributes from nsIUpdatePatch and code related to these attributes. r=mhowell
|
|
||
Comment 10•7 years ago
|
||
| bugherder | ||
You need to log in
before you can comment on or make changes to this bug.
Description
•