Highlight private comments in new bug modal UI

RESOLVED FIXED

Status

()

defect
P1
normal
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: bhearsum, Assigned: imadueme)

Tracking

Production

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

45 bytes, text/x-github-pull-request
Details | Review
This is quite the edge case, but I was looking at a bug from a couple of years ago where I had made some private comments. Since then, I've been removed from the "core security" group. In the new UI, these comments (such as https://bugzilla.mozilla.org/show_bug.cgi?id=1139929#c20) show up exactly the same as other comments - there's no indication that they are private. In the old UI, they are coloured differently.
If you're not in the security groups you shouldn't be able to see the private comment at all, even if it's yours! The example comment above, though, was made not-private a short while after this bug was filed. A current private comment is bug  1396466 comment 11

I completely agree that private comments are no longer distinguishable enough in the new UI. There's a little word "Private" over by the tag button (or perhaps more importantly, the reply button), but the text color or background color are identical as you read down the bug. A different visual style would be nice.
Component: General → User Interface: Modal
Summary: private comments are not highlighted in new bugzilla ui for users not in "core security" → private comments are not highlighted in new bugzilla ui
comment 2 in this bug is a private comment. The comment does have the bz-private class, which is defined as

.bz_private {
	color: darkred;
	background: #f3eeee;
}

This is not having the intended effect. I can make it work by adding !important to each style. The .comment-text style seems to win so you might also be able to make it work by reversing the order these are defined.
Flags: needinfo?(dylan)
Assignee: nobody → dylan
Flags: needinfo?(dylan)
Duplicate of this bug: 1447195
Assignee: dylan → imadueme
Priority: -- → P1
(Assignee)

Updated

a year ago
Status: NEW → ASSIGNED
(Assignee)

Updated

a year ago
Summary: private comments are not highlighted in new bugzilla ui → Highlight private comments in new bug modal UI
(Assignee)

Comment 5

a year ago
Posted file Github PR #545
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.