1373303 - Open One Click Search doesn't do anything when user removed the search bar in the toolbar

Status: NEW

(Firefox :: New Tab Page, defect, P5)

Description

[Dave Townsend [:mossop]]

I suspect because I don't have my search bar in the toolbar but clicking this button in the onboarding tour doesn't do anything.

Comment 1

[KM Lee [:rexboy] (inactivate after Sep. 22)]

So we can receive exception upon not found (the case of deleted by customize UI?).

Some solutions that may be feasible come to me:
1. Show some warning message upon search bar not found
2. Just put the search bar back when receiving error, seems it's supported in UITour.
3. Disable button upon error (Not sure if we can detect this situation from very start)
4. Some combination of above?

This should be a UX decision.
We can do a triage first.

Comment 2

[KM Lee [:rexboy] (inactivate after Sep. 22)]

We may consider the remaining tours of version 56 and 57 which may ran into similar issues:

In version 57:
For both updated users and new users: who remove the screenshot icon manually from customize run into a similar case case.
(UI for library, single search, and customize can’t be removed, so we don’t need to consider these tours.)

In version 56:
For Updated users: this won’t be a case since updated user doesn’t see the tour.
For New users: who remove the find bar manually from customize run into this case. This should be relatively rare case for a new user.

We can prioritize it to be fixed in version 57 since it's relatively difficult to run into in version 56.

Comment 3

[KM Lee [:rexboy] (inactivate after Sep. 22)]

To summarize, the on-discussing things are:

1. What should we do if a ver.57 user removed screenshot icon from customization, then clicked the button on screenshot tour?
2. What should we do if a ver.56 user removed the search bar from customization, then clicked the button on one-off search tour?

Comment 4

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Quick update:
We come to the conclude that we can show some error messages when it get failed to find the search bar.

Comment 5

[Francis Lee [:frlee]]

Per re-prioritisation meeting in SF WW with UX/PM, change this issue to P3.