Closed Bug 1373347 Opened 7 years ago Closed 6 years ago

Intermittent TEST-UNEXPECTED-TIMEOUT | /xhr/send-response-upload-event-progress.htm | XMLHttpRequest: The send() method: Fire a progress event named progress on the XMLHttpRequestUpload (synchronous flag is unset) - Test timed out

Categories

(Core :: DOM: Core & HTML, defect, P3)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: intermittent-bug-filer, Unassigned)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell disabled]) 

I can reproduce timeout on linux using rr.
this failure has increased in frequency in the last 2 weeks and it would be nice to fix this or disable it.

:shawnjohnjr, I see this is assigned to you, can you look into fixing this sometime in the next week or two?
Flags: needinfo?(shuang)
Whiteboard: [stockwell needswork]
(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #13)
> this failure has increased in frequency in the last 2 weeks and it would be
> nice to fix this or disable it.
> 
> :shawnjohnjr, I see this is assigned to you, can you look into fixing this
> sometime in the next week or two?

Yes. I will take a look in the next week. I'm working on P1 bug this week so I can't work this bug immediately.
Flags: needinfo?(shuang)
I can't reproduce this bug using rr. So I will add more logs to try-server.
It seems the frequency is much higher than bug 1370056. I will investigate this bug first.
It looks like the same problem as bug 1370056 used.
As I mentioned in bug 1370056 comment 20, in normal situation, onProgress() will be executed after open() and before load event gets issued, and set mProgressSinceLastProgressEvent to true, then progress event will be sent in OnStartRequest(). In bad situation, it seems onProgress() event delay a bit, and we check the current state is in headers_received so we don't fire progress event.  OnProgress is triggered by nsBaseChannel::OnDataAvailable, it seems like necko doesn't trigger onProgress in time. Then load event was sent first. I have to check why OnDataAvailable doesn't call in time.
(In reply to Shawn Huang [:shawnjohnjr] from comment #19)
> It looks like the same problem as bug 1370056 used.
typo: s/used/had
It looks like the same problem as bug 1370056 had.
DispatchProgressEvent to upload object only happened in both OnStartRequest and HandleProgressTimerCallback. Even to allow to check mState is headers_received in InUploadPhase, HandleProgressTimerCallback doesn't trigger anyway.
Switch to critical 56 beta bug a few days, now I'm focusing this again.
disabled this test case:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba64cdc57937720873e9a096de3f892b817c5873

:shawnjohnjr, please remember to enable this in the manifest when you fix this.
Flags: needinfo?(shuang)
Keywords: leave-open
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]
(In reply to Joel Maher ( :jmaher) (UTC-5) from comment #26)
> disabled this test case:
> https://hg.mozilla.org/integration/mozilla-inbound/rev/
> ba64cdc57937720873e9a096de3f892b817c5873
> 
> :shawnjohnjr, please remember to enable this in the manifest when you fix
> this.

Sorry. I'm again stuck in blockers now. I will revisit these issues again.
Flags: needinfo?(shuang)
Component: web-platform-tests → DOM
Product: Testing → Core
Summary: Intermittent TEST-UNEXPECTED-TIMEOUT | /XMLHttpRequest/send-response-upload-event-progress.htm | XMLHttpRequest: The send() method: Fire a progress event named progress on the XMLHttpRequestUpload (synchronous flag is unset) - Test timed out → Intermittent TEST-UNEXPECTED-TIMEOUT | /xhr/send-response-upload-event-progress.htm | XMLHttpRequest: The send() method: Fire a progress event named progress on the XMLHttpRequestUpload (synchronous flag is unset) - Test timed out
Version: Version 3 → Trunk
Status: NEW → RESOLVED
Closed: 6 years ago
Priority: -- → P3
Resolution: --- → WORKSFORME
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.