1373375 - SeaMonkey extensions and themes are flagged as legacy in add-ons manager.

Status: RESOLVED FIXED

(SeaMonkey :: General, enhancement)

Description

[Frank-Rainer Grahl (:frg)]

In Nightly all extensions and themes are flagged as legacy. This should not happen for the ones distributed with SeaMonkey.

Comment 1

[Frank-Rainer Grahl (:frg)]

Attachment: 1373375-extensionslegacy.patch

Not so sure if the startup scope should be extended to 15 but some code for directory scans was recently removed from toolkit. TB currently uses 4.

Comment 2

[Ian Neal]

Comment on attachment 8878184 [details] [diff] [review]
1373375-extensionslegacy.patch

> // Disable add-ons installed into the shared user and shared system areas by
> // default. This does not include the application directory. See the SCOPE
> // constants in AddonManager.jsm for values to use here.
> pref("extensions.autoDisableScopes", 15);
> 
>+// Enable add-ons installed and owned by the application, like the default theme.
Does the comment match the value, it seems to only describe if it was 4.
>+pref("extensions.startupScanScopes", 15);
Have you tested against different values? Is 4 sufficient?

>+
>+pref("extensions.legacy.enabled", true);
>+// Extensions that should not be flagged as legacy in about:addons
>+// {972ce4c6-7e08-4474-a285-3208198ce6fd} default theme
>+// {59c81df5-4b7a-477b-912d-4e0fdf64e5f2} chatZilla
>+// {e2fda1a4-762b-4020-b5ad-a41df1933103} calendar
>+pref("extensions.legacy.exceptions", "{972ce4c6-7e08-4474-a285-3208198ce6fd},[e-mail],[e-mail],[e-mail],{59c81df5-4b7a-477b-912d-4e0fdf64e5f2},{e2fda1a4-762b-4020-b5ad-a41df1933103}");
Should we also include DOMi?

r=me with those addressed.

Comment 3

[Frank-Rainer Grahl (:frg)]

> Have you tested against different values? Is 4 sufficient?

Unsure. I will need to retest it. A comment from Jorg in the TB bug indicated that 15 is maybe necessary.

> Should we also include DOMi?

It is already in: [e-mail]. I put only the extensions with id as the name in the comment for clarification.

I am not sure about langauge packs but Fx do not seem to have them in the pref yet.

Comment 4

[Frank-Rainer Grahl (:frg)]

Attachment: 1373375-extensionslegacy-V2.patch

4 should be sufficient. But I forgot to include the MOZ_ALLOW_LEGACY_EXTENSIONS build var (which is 1 now but you never know) so asking for review again.

Comment 5

[Ian Neal]

Comment on attachment 8881235 [details] [diff] [review]
1373375-extensionslegacy-V2.patch

r=me

Comment 6

[Frank-Rainer Grahl (:frg)]

https://hg.mozilla.org/comm-central/rev/ccbd9c80a4ddd761cc7e7c24c3886cf8412bda35