1373422 - Non-restartless legacy extensions aren't disabled without a restart

Status: RESOLVED WORKSFORME

(Toolkit :: Add-ons Manager, defect)

Description

[krupa raj [:krupa--use this to needinfo]]

56.0a1 (2017-06-15) (64-bit)

steps to reproduce:
1. In about:config, toggle the value of extensions.legacy.enabled to true
2. On your nightly install a restartless legacy extension like NoScript. Make sure NoScript is working.
3. In about:config, toggle the value of extensions.legacy.enabled to false
4. Load about:addons
5. Notice that there is warning that noScript will be disabled after restart

expected behavior:
If extensions.legacy.enabled to false, then all legacy extensions are disabled.

observed behavior:
Only restartless legacy extensions are disabled.

If the user doesn't restart the browser, a legacy extension like NoScript will keep running even though the pref is toggled to not support them. 

Things to check:
* Need to make sure that when the user upgrades to 57, the browser upgrade takes care of the add-on disable as well.


For andy and kev:
Is this behavior something we are okay with?

Comment 1

[Andy McKay]

When a browser upgrades to Firefox 57 there will be a restart and the add-on won't be loaded. It's an unfortunate legacy of non-restartless add-ons.

I'm fine with this behaviour.

Comment 2

[Kev Needham [:kev]]

Concur.

(In reply to Andy McKay [:andym] from comment #1)
> When a browser upgrades to Firefox 57 there will be a restart and the add-on
> won't be loaded. It's an unfortunate legacy of non-restartless add-ons.
> 
> I'm fine with this behaviour.