1373487 - permissions UI is not helpful for about: pages

Status: VERIFIED FIXED

(Firefox :: Site Identity, enhancement, P3)

Description

[Robert Helmer [:rhelmer]]

Attachment: site permissions UI on about:addons

While per-site permissions are used in about: pages in some cases (to grant UI Tour permissions to about: content pages for instance), this is all internal and the user can't actually revoke permissions.

Unless we're going to allow users to revoke permissions on internal browser UI pages, we should just not display the permissions bit.

This is what Chrome does too, incidentally.

Comment 1

[Johann Hofmann [:johannh]]

Hm, these pages can _technically_ have permissions set in the permission manager. I can understand that they won't realistically have that, though (we should check in any case). What would be your logic for that? .startsWith("about:")?

Comment 2

[:Gijs (he/him)]

(In reply to Johann Hofmann [:johannh] from comment #1)
> What would be your logic for that?
> .startsWith("about:")?

I think we shouldn't bother showing it for anything for which we show a chromeUI identity block.

Comment 3

[:prathiksha]

Attachment: Bug 1373487 - Don't display permission content in the control center for internal pages.

Review commit: https://reviewboard.mozilla.org/r/168222/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/168222/

Comment 4

[Johann Hofmann [:johannh]]

Comment on attachment 8896935 [details]
Bug 1373487 - Don't display permission content in the control center for internal pages.

https://reviewboard.mozilla.org/r/168222/#review173410

This can actually be solved way easier, sorry for pointing you in the wrong direction initially. There's a "when-connection" pseudo-attribute on items in the identity block (https://searchfox.org/mozilla-central/rev/6482c8a5fa5c7446e82ef187d1a1faff49e3379e/browser/components/controlcenter/content/panel.inc.xul#57). You can add this to the container here: https://searchfox.org/mozilla-central/rev/6482c8a5fa5c7446e82ef187d1a1faff49e3379e/browser/components/controlcenter/content/panel.inc.xul#86

It should be the same as for the tracking protection block, but we should probably include the "extension" connection type as well. (I wonder if tracking protection is missing that for a reason or on accident).

Comment 5

[:prathiksha]

Comment on attachment 8896935 [details]
Bug 1373487 - Don't display permission content in the control center for internal pages.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/168222/diff/1-2/

Comment 6

[Johann Hofmann [:johannh]]

Comment on attachment 8896935 [details]
Bug 1373487 - Don't display permission content in the control center for internal pages.

https://reviewboard.mozilla.org/r/168222/#review173488

Looks great, thank you!

Comment 7

[:prathiksha]

Comment on attachment 8896935 [details]
Bug 1373487 - Don't display permission content in the control center for internal pages.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/168222/diff/2-3/

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0157f48f3390
Don't display permission content in the control center for internal pages.r=johannh

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/0157f48f3390

Comment 10

[Johann Hofmann [:johannh]]

Screenshots:

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=b95b1638db48fc3d450b95b98da6bcd2f9326d2f&newProject=mozilla-central&newRev=b4b58cf12108a0b49db77781bdcab8cc481fb64b&filter=about

Looking great!

Comment 11

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I'm confirming that bug is fixed, starting in Mozilla Firefox Nightly 57.0a1 (2017-08-15), so I'm marking this bug as VERIFIED. Thanks.