Open Bug 1373558 Opened 6 years ago Updated 1 year ago

Intermittent devtools/client/netmonitor/test/browser_net_statistics-01.js | Test timed out -

Categories

(DevTools :: Netmonitor, defect, P2)

Product:
DevTools
Component:
Netmonitor
Type:
defect

Tracking

(firefox57 fix-optional)

Tracking Flags:
Tracking Status
firefox57 --- fix-optional

People

(Reporter: aryx, Unassigned)

Details

(Keywords: intermittent-failure, leave-open, stale-bug, Whiteboard: [stockwell disabled])

Attachments

(2 files)

Bug 1373558 - Wait for next idle;
59 bytes, text/x-review-board-request
Details
Skiped the test
625 bytes, patch
gbrown
: review+
Details | Diff | Splinter Review 
+++ This bug was initially created as a clone of Bug #1285173 +++

22:32:33     INFO - TEST-START | devtools/client/netmonitor/test/browser_net_sort-02.js
22:32:36     INFO - GECKO(2640) | MEMORY STAT | vsize 2121MB | vsizeMaxContiguous 6620292MB | residentFast 354MB | heapAllocated 182MB
22:32:36     INFO - TEST-OK | devtools/client/netmonitor/test/browser_net_sort-02.js | took 3527ms
22:32:36     INFO - checking window state
22:32:36     INFO - GECKO(2640) | JavaScript error: resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/netmonitor/src/connector/firefox-connector.js, line 92: TypeError: this.tabTarget is null
22:32:36     INFO - TEST-START | devtools/client/netmonitor/test/browser_net_statistics-01.js
22:33:04     INFO -  JavaScript error: resource://gre/modules/FormHistory.jsm, line 379: NS_ERROR_FAILURE: Component returned failure code: 0x80004005 (NS_ERROR_FAILURE) [nsIProperties.get]
22:33:25     INFO - TEST-INFO | started process screenshot
22:33:25     INFO - TEST-INFO | screenshot: exit 0
22:33:25     INFO - Buffered messages logged at 22:32:36
22:33:25     INFO - Entering test bound 
22:33:25     INFO - Initializing a network monitor pane.
22:33:25     INFO - Adding a new tab with URL: http://example.com/browser/devtools/client/netmonitor/test/html_statistics-test-page.html
22:33:25     INFO - Console message: [JavaScript Error: "TypeError: this.tabTarget is null" {file: "resource://gre/modules/commonjs/toolkit/loader.js -> resource://devtools/client/netmonitor/src/connector/firefox-connector.js" line: 92}]
22:33:25     INFO - Buffered messages logged at 22:32:38
22:33:25     INFO - Tab added and finished loading
22:33:25     INFO - Net tab added successfully: http://example.com/browser/devtools/client/netmonitor/test/html_statistics-test-page.html
22:33:25     INFO - Target remoted.
22:33:25     INFO - Console message: [JavaScript Warning: "Expected end of value but found ‘1pxpx’.  Error in parsing value for ‘flex’.  Declaration dropped." {file: "chrome://devtools/content/netmonitor/index.html" line: 0 column: 4 source: "0 0 1pxpx"}]
22:33:25     INFO - Network monitor pane shown successfully.
22:33:25     INFO - Disabling cache and reloading page.
22:33:25     INFO - Request server1.conn88.child1/netEvent30 for http://example.com/browser/devtools/client/netmonitor/test/html_statistics-test-page.html not yet done, keep waiting...
22:33:25     INFO - Buffered messages finished
22:33:25     INFO - TEST-UNEXPECTED-FAIL | devtools/client/netmonitor/test/browser_net_statistics-01.js | Test timed out -
This is a P1 bug without an assignee. 

P1 are bugs which are being worked on for the current release cycle/iteration/sprint. 

If the bug is not assigned by Monday, 28 August, the bug's priority will be reset to '--'.
Keywords: stale-bug
There have been 30 failures in the last week, according to Orange Factor.
This bug started to occur again on January 15th.

Occurrences per platform:
Windows 7: 12
OS X 10.10: 8
linux64-stylo-disabled: 4
Linux x64: 3
windows10-64: 1
linux64-ccov: 1
Linux: 1

Occurrences per build type:
debug: 17
opt: 11
asan: 2

Here is a recent relevant log file and a snippet with the failure:
https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=157526291&lineNumber=12267

08:00:31     INFO -  350 INFO Waiting for chart to display
12266
08:00:31     INFO -  Buffered messages finished
12267
08:00:31    ERROR -  351 INFO TEST-UNEXPECTED-FAIL | devtools/client/netmonitor/test/browser_net_statistics-01.js | Test timed out -
12268
08:00:31     INFO -  GECKO(6032) | ++DOMWINDOW == 16 (0086F400) [pid = 6032] [serial = 463] [outer = 008F13A0]
12269
08:00:31     INFO -  GECKO(6032) | --DOCSHELL 0EDB5400 == 5 [pid = 6032] [id = {d0a16dc6-3969-472c-8085-25ce7722f3b4}]
12270
08:00:31     INFO -  GECKO(6032) | --DOCSHELL 0E42DC00 == 4 [pid = 6032] [id = {85ce119c-0fe9-4c18-8ac5-61a8dbde4673}]
12271
08:00:31     INFO -  352 INFO Removing tab.

:Honza, could you please take another look? Thank you!
Flags: needinfo?(odvarko)
Whiteboard: [stockwell needswork]
Over the last 7 days there are 37 failures present. Most of them happen on Linux, Linux x64, linux64-nightly, macosx64-nightly, Windows 7 and Windows 10-64

Here is the most recent log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=158977464&lineNumber=7759

Here is a relevant snippet from the aforementioned log: 

[task 2018-01-28T22:29:31.030Z] 22:29:31     INFO - 
[task 2018-01-28T22:29:31.031Z] 22:29:31     INFO - Buffered messages finished
[task 2018-01-28T22:29:31.032Z] 22:29:31     INFO - TEST-UNEXPECTED-FAIL | devtools/client/netmonitor/test/browser_net_statistics-01.js | Test timed out - 
[task 2018-01-28T22:29:31.094Z] 22:29:31     INFO - Removing tab.
[task 2018-01-28T22:29:31.094Z] 22:29:31     INFO - Waiting for event: 'TabClose' on [object XULElement].
[task 2018-01-28T22:29:31.110Z] 22:29:31     INFO - Got event: 'TabClose' on [object XULElement].
[task 2018-01-28T22:29:31.118Z] 22:29:31     INFO - Tab removed and finished closing
[task 2018-01-28T22:29:31.119Z] 22:29:31     INFO - finish() was called, cleaning up...
In the last 7 days we have 184 failures.
They occur on Linux (opt, debug), Linux x64 enabled and disabled (opt, asan, pgo, debug), macosx64-nightly (opt), OS X 10.10 (debug, opt), Windows 7 (debug), windows10-64 (debug, opt, pgo).

Recent failure log: https://treeherder.mozilla.org/logviewer.html#?repo=autoland&job_id=160495467&lineNumber=7266


14:42:36     INFO - TEST-UNEXPECTED-FAIL | devtools/client/netmonitor/test/browser_net_statistics-01.js | Test timed out - 
7267
14:42:36     INFO - Removing tab.
7268
14:42:36     INFO - Waiting for event: 'TabClose' on [object XULElement].
7269
14:42:36     INFO - Got event: 'TabClose' on [object XULElement].
7270
14:42:36     INFO - Tab removed and finished closing
@Alex: I am not sure why waiting helps in this test (btw. waitForNextTick() seems to help too), but I am not seeing the failure any more...

Honza
Flags: needinfo?(odvarko)
Attached patch Skiped the test — — Splinter Review 

        Attachment #8949413 -
        Flags: review?(gbrown)

    
    

    
  
(In reply to Jan Honza Odvarko [:Honza] from comment #17)
> @Alex: I am not sure why waiting helps in this test (btw. waitForNextTick()
> seems to help too), but I am not seeing the failure any more...

I imagine it highlights a race when we open the statistics panel while the page is still loading?
Using an idle callback would just hide the race.

May be there is something in initNetmonitor that isn't waiting correctly for all async/lazy events
  https://searchfox.org/mozilla-central/source/devtools/client/netmonitor/test/head.js#297-300
May be it is easier to open an empty document first and wait for all necessary event after:
  initNetmonitor("data:text/html,test")
  let onA = waitForA()
  let onB = waitForB()
  tab.linkedBrowser.loadURI(STATISTICS_URL);
  await onA;
  await onB;

Were you able to reproduce locally?
If yes, was the statistic panel broken in some way?

    
    

    
  
Comment on attachment 8949410 [details]
Bug 1373558 - Wait for next idle;

Using a delay like this is only hidding the issue.
This test failure may highlight that statistics panel is broken when opened during page load.

        Attachment #8949410 -
        Flags: review?(poirot.alex)

    
    

    
  
Comment on attachment 8949413 [details] [diff] [review]
Skiped the test

Review of attachment 8949413 [details] [diff] [review]:
-----------------------------------------------------------------

Nice to see your efforts here :honza and :ochameau - thanks.

Since this is failing so frequently, I think we'll go ahead with skipping the test for now. Hopefully you can get it running again soon.

        Attachment #8949413 -
        Flags: review?(gbrown) → review+

    
    

    
  
Pushed by gbrown@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c72473649714
disable browser_net_statistics-01.js for intermittent failures r=gbrown
Keywords: leave-open
Whiteboard: [stockwell disable-recommended] → [stockwell disabled]

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
    

    
      
  

    
  
Product: Firefox → DevTools

    
  
Severity: normal → S3

          You need to log in
          before you can comment on or make changes to this bug.