1373559 - Gecko incorrectly applies style from removed @import rule

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Xidorn Quan [:xidorn] UTC+10]

Attachment: testcase

See the attached testcase.

Gecko shows a red text while it should be unstyled, but Stylo seems to handle this correctly.

Comment 1

[Emilio Cobos Álvarez (:emilio)]

I see unstyled on Gecko, fwiw... Timing-sensitive?

Comment 2

[Xidorn Quan [:xidorn] UTC+10]

Oh, hmmmm......

Interesting...

This was actually fixed by my patch not very long ago...

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Let's land that test-case.

Comment 4

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1373559: Test that removed import rules no longer apply to the document.

Review commit: https://reviewboard.mozilla.org/r/150046/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150046/

Comment 5

[Emilio Cobos Álvarez (:emilio)]

I wanted to upstream it, but couldn't find a suitable-folder in w3c-css for it. Should I create a new one under css21? Meanwhile I guess we can land it in layout/reftests/css-import.

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8878724 [details]
Bug 1373559: Test that removed import rules no longer apply to the document.

https://reviewboard.mozilla.org/r/150046/#review155428

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4d2d5d5342ef
Test that removed import rules no longer apply to the document. r=xidorn

Comment 8

[Xidorn Quan [:xidorn] UTC+10]

(In reply to Emilio Cobos Álvarez [:emilio] from comment #5)
> I wanted to upstream it, but couldn't find a suitable-folder in w3c-css for
> it. Should I create a new one under css21? Meanwhile I guess we can land it
> in layout/reftests/css-import.

I don't think it's worth upstreaming, actually... This is pretty much an engine-specific bug. It seems to me Blink doesn't render it correctly, but in a different way, though...

Comment 9

[Emilio Cobos Álvarez (:emilio)]

(In reply to Xidorn Quan [:xidorn] UTC+10 from comment #8)
> (In reply to Emilio Cobos Álvarez [:emilio] from comment #5)
> > I wanted to upstream it, but couldn't find a suitable-folder in w3c-css for
> > it. Should I create a new one under css21? Meanwhile I guess we can land it
> > in layout/reftests/css-import.
> 
> I don't think it's worth upstreaming, actually... This is pretty much an
> engine-specific bug. It seems to me Blink doesn't render it correctly, but
> in a different way, though...

I do think those tests are extremely valuable, actually... But I'll bite the bullet for this one I guess :)

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/4d2d5d5342ef