13737 - MLK: - 60 bytes leaked- webshell or OnLinkClickEvent::HandleEvent()?

Status: VERIFIED WORKSFORME

(Core Graveyard :: Embedding: APIs, defect, P3)

Description

[Bruce Mitchener]

Solaris 2.6, gcc 2.7.2.3.  Build from September 13, 1999.  Opened viewer, loaded
initial page, went to www.visa.com, selected the 'back to school' specials link,
quit.


MLK: 60 bytes leaked at 0xa01568
  * This memory was allocated from:
        malloc         [rtlib.o]
        __bUiLtIn_nEw  [libraptorgfx.so]
        __builtin_new  [rtlib.o]
        nsStdURL::Create(nsISupports*,const nsID&,void**) [nsStdURL.cpp:628]
        nsGenericFactory::CreateInstance(nsISupports*,const nsID&,void**)
[nsGenericFactory.cpp:37]
        nsComponentManagerImpl::CreateInstance(const nsID&,nsISupports*,const
nsID&,void**) [nsComponentManager.cpp:1218]
        nsComponentManager::CreateInstance(const nsID&,nsISupports*,const
nsID&,void**) [nsRepository.cpp:77]
        nsHTTPHandler::NewURI(const char*,nsIURI*,nsIURI**)
[nsHTTPHandler.cpp:262]
        nsIOService::NewURI(const char*,nsIURI*,nsIURI**) [nsIOService.cpp:200]
        NS_NewURI(nsIURI**,const char*,nsIURI*) [nsNeckoUtil.cpp:36]
        NS_NewURI(nsIURI**,const nsString&,nsIURI*) [nsNeckoUtil.cpp:49]
        nsWebShell::LoadURL(const unsigned short*,const
char*,nsIInputStream*,int,unsigned int,unsigned int,nsISupports*)
[nsWebShell.cpp:2448]
        nsWebShell::LoadURL(const unsigned short*,nsIInputStream*,int,unsigned
int,unsigned int,nsISupports*) [nsWebShell.cpp:2089]
        nsWebShell::HandleLinkClickEvent(nsIContent*,nsLinkVerb,const unsigned
short*,const unsigned short*,nsIInputStream*) [nsWebShell.cpp:3203]
        OnLinkClickEvent::HandleEvent() [nsWebShell.cpp:3030]
        HandlePLEvent(OnLinkClickEvent*) [nsWebShell.cpp:3043]
        PL_HandleEvent [plevent.c:509]
        PL_ProcessPendingEvents [plevent.c:470]
        nsEventQueueImpl::ProcessPendingEvents() [nsEventQueue.cpp:118]
        event_processor_callback(void*,int,GdkInputCondition)
[nsAppShell.cpp:153]
        gdk_io_invoke  [gdkevents.c:868]
        g_io_unix_dispatch [giounix.c:131]
        g_main_dispatch [gmain.c:647]
        g_main_iterate [gmain.c:854]
        g_main_run     [gmain.c:912]
        gtk_main       [gtkmain.c:475]
        nsAppShell::Run() [nsAppShell.cpp:379]
        nsNativeViewerApp::Run() [nsGtkMain.cpp:42]
        main           [nsGtkMain.cpp:116]
        _start         [crt1.o]

Comment 1

[brendan-obsolete]

This doesn't look like nisheeth or vidur to me; cc'ing likely perps. ;-)

/be

Comment 2

[Suresh Duddi (gone)]

ugh! My best guess is nsWebShell::LoadURL() isn't deleting the new url it got
in the url completion routine. Is that where urls objects get deleted gagan ?

Comment 3

[Gagan]

I am not sure where this is being done. But the last user of the URI would
probably be OnEndRequest in a URL fetch. If you are only constructing URIs for
autocompletion then I guess you should release them as soon as you are done.

Comment 4

[Nisheeth Ranjan]

Accepting bug and setting milestone to M12...

Comment 5

[Nisheeth Ranjan]

The problem is in the webshell for this one based on a quick onceover.  I'm
working on a fix.  Bringing in the milestone to M11...

Comment 6

[Nisheeth Ranjan]

I went off to Connecticut for three days and now that I get back, it seems that
this leak has been fixed.  Bruce, could you verify that?  I purified today's
build, loaded viewer, went to www.visa.com, couldn't find the "back to school"
link but clicked on the "Featured Deal and Discounts" link, and exited.  Purify
did not report the above leak.

I'm ccing Rick Potts to ask him whether he fixed some leaks in nsWebshell or
nsDocLoader over the last few days.  Rick?

Comment 7

[Nisheeth Ranjan]

This leak has been fixed.  Marking bug worksforme.

Comment 8

[Paul Wyskoczka]

Verified