1373761 - Add PROFILER_LABEL with URLs for nsInProcessTabChildGlobal::LoadFrameScript

Status: RESOLVED FIXED

(Core :: Gecko Profiler, enhancement)

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1373761 - Add a PROFILER_LABEL to nsMessageManagerScriptExecutor::LoadScriptInternal.

Review commit: https://reviewboard.mozilla.org/r/149960/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/149960/

Comment 2

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8878663 [details]
Bug 1373761 - Add a PROFILER_LABEL to nsMessageManagerScriptExecutor::LoadScriptInternal.

https://reviewboard.mozilla.org/r/149960/#review155282

::: dom/base/nsInProcessTabChildGlobal.cpp:327
(Diff revision 1)
>    nsString mURL;
>    bool mRunInGlobalScope;
>  };
>  
>  void
>  nsInProcessTabChildGlobal::LoadFrameScript(const nsAString& aURL, bool aRunInGlobalScope)

It seems a bit odd to have a label for the in-process case but not the out-of-process case (at least I couldn't find one). Could you instead move this here to cover both?
https://searchfox.org/mozilla-central/rev/7cc377ce3f0a569c5c9b362d589705cd4fecc0ac/dom/base/nsFrameMessageManager.cpp#1520

Comment 3

[Markus Stange [:mstange]]

Comment on attachment 8878663 [details]
Bug 1373761 - Add a PROFILER_LABEL to nsMessageManagerScriptExecutor::LoadScriptInternal.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/149960/diff/1-2/

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8878663 [details]
Bug 1373761 - Add a PROFILER_LABEL to nsMessageManagerScriptExecutor::LoadScriptInternal.

https://reviewboard.mozilla.org/r/149960/#review155292

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/104526191e22
Add a PROFILER_LABEL to nsMessageManagerScriptExecutor::LoadScriptInternal. r=billm

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/104526191e22