Closed Bug 1373761 Opened 8 years ago Closed 8 years ago

Add PROFILER_LABEL with URLs for nsInProcessTabChildGlobal::LoadFrameScript

Categories

(Core :: Gecko Profiler, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: mstange, Assigned: mstange)

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8878663 [details] Bug 1373761 - Add a PROFILER_LABEL to nsMessageManagerScriptExecutor::LoadScriptInternal. https://reviewboard.mozilla.org/r/149960/#review155282 ::: dom/base/nsInProcessTabChildGlobal.cpp:327 (Diff revision 1) > nsString mURL; > bool mRunInGlobalScope; > }; > > void > nsInProcessTabChildGlobal::LoadFrameScript(const nsAString& aURL, bool aRunInGlobalScope) It seems a bit odd to have a label for the in-process case but not the out-of-process case (at least I couldn't find one). Could you instead move this here to cover both? https://searchfox.org/mozilla-central/rev/7cc377ce3f0a569c5c9b362d589705cd4fecc0ac/dom/base/nsFrameMessageManager.cpp#1520
Attachment #8878663 - Flags: review?(wmccloskey)
Comment on attachment 8878663 [details] Bug 1373761 - Add a PROFILER_LABEL to nsMessageManagerScriptExecutor::LoadScriptInternal. https://reviewboard.mozilla.org/r/149960/#review155292
Attachment #8878663 - Flags: review?(wmccloskey) → review+
Pushed by mstange@themasta.com: https://hg.mozilla.org/integration/autoland/rev/104526191e22 Add a PROFILER_LABEL to nsMessageManagerScriptExecutor::LoadScriptInternal. r=billm
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Assignee: nobody → mstange
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: