1373786 - Mapping of "article" role and element is incorrect for AX API and ATK

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement)

Description

[Joanmarie Diggs]

The HTML AAM states that the mapping for the article element is to "use the WAI-ARIA role." The mapping for the ARIA "article" role [1] is:

AX API: AXGroup, with subrole AXDocumentArticle
ATK: ROLE_ARTICLE

Gecko, however, exposes articles as AXWebArea (no subrole) for AX API, and ROLE_DOCUMENT_FRAME for ATK.

Note: I'm spinning this issue off of bug 1305446 because the log mapping has additional issues.

[1] https://rawgit.com/w3c/aria/master/core-aam/core-aam.html#role-map-article

Comment 1

[Joanmarie Diggs]

Attachment: proposed patch

Comment 2

[alexander :surkov (:asurkov)]

Comment on attachment 8878658 [details] [diff] [review]
proposed patch

Review of attachment 8878658 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, thanks!

Comment 3

[Ryan VanderMeulen [:RyanVM]]

For future patches, please try to use a commit message which describes what the patch is actually doing instead of simply restating the problem being solved. Thanks!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c5e6e176f18
Mapping of "article" role and element is incorrect for AX API and ATK. r=surkov

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Sorry, I meant to include a link to more documentation with that last comment.
http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/commits.html#write-detailed-commit-messages

Comment 6

[alexander :surkov (:asurkov)]

(In reply to Ryan VanderMeulen [:RyanVM] from comment #3)
> For future patches, please try to use a commit message which describes what
> the patch is actually doing instead of simply restating the problem being
> solved. Thanks!

How would you improve the commit message? It was just a fix of 'article' ARIA role mapping for mac and linux APIs. Use 'fix' word instead 'is incorrect' or something else?

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/7c5e6e176f18