Closed Bug 1373786 Opened 2 years ago Closed 2 years ago

Mapping of "article" role and element is incorrect for AX API and ATK

Categories

(Core :: Disability Access APIs, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: jdiggs, Assigned: jdiggs)

Details

Attachments

(1 file)

The HTML AAM states that the mapping for the article element is to "use the WAI-ARIA role." The mapping for the ARIA "article" role [1] is:

AX API: AXGroup, with subrole AXDocumentArticle
ATK: ROLE_ARTICLE

Gecko, however, exposes articles as AXWebArea (no subrole) for AX API, and ROLE_DOCUMENT_FRAME for ATK.

Note: I'm spinning this issue off of bug 1305446 because the log mapping has additional issues.

[1] https://rawgit.com/w3c/aria/master/core-aam/core-aam.html#role-map-article
Attached patch proposed patchSplinter Review
Assignee: nobody → jdiggs
Status: NEW → ASSIGNED
Attachment #8878658 - Flags: review?(surkov.alexander)
Comment on attachment 8878658 [details] [diff] [review]
proposed patch

Review of attachment 8878658 [details] [diff] [review]:
-----------------------------------------------------------------

r=me, thanks!
Attachment #8878658 - Flags: review?(surkov.alexander) → review+
For future patches, please try to use a commit message which describes what the patch is actually doing instead of simply restating the problem being solved. Thanks!
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/7c5e6e176f18
Mapping of "article" role and element is incorrect for AX API and ATK. r=surkov
Keywords: checkin-needed
(In reply to Ryan VanderMeulen [:RyanVM] from comment #3)
> For future patches, please try to use a commit message which describes what
> the patch is actually doing instead of simply restating the problem being
> solved. Thanks!

How would you improve the commit message? It was just a fix of 'article' ARIA role mapping for mac and linux APIs. Use 'fix' word instead 'is incorrect' or something else?
https://hg.mozilla.org/mozilla-central/rev/7c5e6e176f18
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.