1373817 - CSS Shapes Highlighter: toggle between length units

Status: NEW

(DevTools :: Inspector, enhancement, P3)

Description

[Mike Park [:mparkms]]

The CSS shapes highlighter currently outputs all values in percentages when a shape is edited. There should be some way of toggling the values between percentages (a relative unit) to pixels (an absolute unit). This toggling can be applied to either the entire shape definition, or to individual points.

Comment 1

[Mike Park [:mparkms]]

This should include not just px/% but also other length units such as em/rem/pt/in/vl/vw, etcetera.

Comment 2

[Mike Park [:mparkms]]

Attachment: Bug 1373817 - Convert between length units in CSS shapes highlighter.

Review commit: https://reviewboard.mozilla.org/r/159354/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159354/

Comment 3

[Mike Park [:mparkms]]

Comment on attachment 8888408 [details]
Bug 1373817 - Convert between length units in CSS shapes highlighter.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159354/diff/1-2/

Comment 4

[Mike Park [:mparkms]]

Comment on attachment 8888408 [details]
Bug 1373817 - Convert between length units in CSS shapes highlighter.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159354/diff/2-3/

Comment 5

[Mike Park [:mparkms]]

Comment on attachment 8888408 [details]
Bug 1373817 - Convert between length units in CSS shapes highlighter.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159354/diff/3-4/

Comment 6

[Patrick Brosset <:pbro>]

I'm going to cancel the review for now, until we have some more UX/design time on this tool. The reason is that I'm not comfortable with the shift+click approach as it's not discoverable at all.
This is also the case with the ctrl+click (on the icon) to start the transform tool. 
I'd like us to revisit those at some stage.

Comment 7

[Patrick Brosset <:pbro>]

Resetting the assignee field so others can pick this bug up, since it has been 1 year. Feel free to claim it again if you did intend to work on it after all.