Closed
Bug 1373833
Opened 7 years ago
Closed 6 years ago
Implement scroll-margin-* properties
Categories
(Core :: CSS Parsing and Computation, enhancement, P3)
Tracking
()
RESOLVED
FIXED
mozilla68
People
(Reporter: sebo, Assigned: hiro)
References
(Blocks 2 open bugs, )
Details
(Keywords: dev-doc-complete)
Attachments
(1 file, 1 obsolete file)
The latest CSS Scroll Snap spec. defines several scroll-snap-margin-* properties, which specify the scroll snap area that is used for snapping the box to the snapport.
These properties should be implemented accordingly.
Sebastian
|
||
Updated•7 years ago
|
Priority: -- → P3
|
|
||
Updated•7 years ago
|
status-firefox57:
--- → wontfix
|
Assignee | |
Comment 1•6 years ago
|
||
I guess scroll-snap-margin-* properties have been merged into a single property named scroll-margin.
Summary: Implement scroll-snap-margin-* properties → Implement scroll-margin property
|
|
Assignee | |
Comment 2•6 years ago
|
||
Oh it's a shorthand. :)
|
Reporter | |
Comment 3•6 years ago
|
||
(In reply to Hiroyuki Ikezoe (:hiro) from comment #2)
> Oh it's a shorthand. :)
Right, therefore I've changed the summary again to cover all of them. Not sure whether this should be further split up into bugs for the physical and flow-relative properties, though.
Sebastian
Summary: Implement scroll-margin property → Implement scroll-margin-* properties
|
|
Assignee | |
Updated•6 years ago
|
Assignee: nobody → hikezoe
Status: NEW → ASSIGNED
|
|
Assignee | |
Comment 5•6 years ago
|
||
FWIW, here is the patch for this bug. Once after bug 1373835 landed, I will revisit to this bug.
|
|
Assignee | |
Comment 6•6 years ago
|
||
scroll-margin is for each elements in the scroll container and snap positions
are shifted by the value.
https://drafts.csswg.org/css-scroll-snap-1/#scroll-margin
https://drafts.csswg.org/css-scroll-snap-1/#scroll-snap-area
|
|
Assignee | |
Updated•6 years ago
|
Attachment #9045477 -
Attachment is obsolete: true
|
||
Comment 7•6 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:hiro, could you have a look please?
Flags: needinfo?(hikezoe)
|
|
Assignee | |
Comment 8•6 years ago
|
||
I am just waiting for jfkthame's review in bug 1373835.
Flags: needinfo?(hikezoe)
|
|
||
Comment 9•6 years ago
|
||
There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:hiro, could you have a look please?
Flags: needinfo?(hikezoe)
|
||
Comment 10•6 years ago
|
||
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/acbcbc1dc6e0
Factor scroll-margin values into scroll snap position calculation. r=botond
|
||
Comment 11•6 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox68:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
|
|
Assignee | |
Updated•6 years ago
|
Flags: needinfo?(hikezoe)
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/16482 for changes under testing/web-platform/tests
Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/16482
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/SQhDs-wLQWCd5q8NBrsYtg)
Upstream PR merged
|
||
Updated•5 years ago
|
Keywords: dev-doc-needed → dev-doc-complete
|
|
||
Comment 15•5 years ago
|
||
These are documented and a note added to the 68 release notes https://developer.mozilla.org/en-US/docs/Web/CSS/scroll-margin
You need to log in
before you can comment on or make changes to this bug.
Description
•