Closed Bug 1373833 Opened 2 years ago Closed 6 months ago

Implement scroll-margin-* properties

Categories

(Core :: CSS Parsing and Computation, enhancement, P3)

53 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox57 --- wontfix
firefox68 --- fixed

People

(Reporter: sebo, Assigned: hiro)

References

(Blocks 2 open bugs, )

Details

(Keywords: dev-doc-complete)

Attachments

(1 file, 1 obsolete file)

The latest CSS Scroll Snap spec. defines several scroll-snap-margin-* properties, which specify the scroll snap area that is used for snapping the box to the snapport.

These properties should be implemented accordingly.

Sebastian
Priority: -- → P3
I guess scroll-snap-margin-* properties have been merged into a single property named scroll-margin.
Summary: Implement scroll-snap-margin-* properties → Implement scroll-margin property
Oh it's a shorthand. :)
(In reply to Hiroyuki Ikezoe (:hiro) from comment #2)
> Oh it's a shorthand. :)

Right, therefore I've changed the summary again to cover all of them. Not sure whether this should be further split up into bugs for the physical and flow-relative properties, though.

Sebastian
Summary: Implement scroll-margin property → Implement scroll-margin-* properties
Depends on: 1528639

This needs scroll-snap-align implementation.

Depends on: 1373835
Depends on: 1529219
Assignee: nobody → hikezoe
Status: NEW → ASSIGNED

FWIW, here is the patch for this bug. Once after bug 1373835 landed, I will revisit to this bug.

Attachment #9045477 - Attachment is obsolete: true

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:hiro, could you have a look please?

Flags: needinfo?(hikezoe)

I am just waiting for jfkthame's review in bug 1373835.

Flags: needinfo?(hikezoe)

There's a r+ patch which didn't land and no activity in this bug for 2 weeks.
:hiro, could you have a look please?

Flags: needinfo?(hikezoe)
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/acbcbc1dc6e0
Factor scroll-margin values into scroll snap position calculation. r=botond
Status: ASSIGNED → RESOLVED
Closed: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Flags: needinfo?(hikezoe)
Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/16482 for changes under testing/web-platform/tests
Can't merge web-platform-tests PR due to failing upstream checks:
Github PR https://github.com/web-platform-tests/wpt/pull/16482
* Taskcluster (pull_request) (https://tools.taskcluster.net/task-group-inspector/#/SQhDs-wLQWCd5q8NBrsYtg)
Upstream PR merged

These are documented and a note added to the 68 release notes https://developer.mozilla.org/en-US/docs/Web/CSS/scroll-margin

You need to log in before you can comment on or make changes to this bug.