Closed Bug 1373887 Opened 3 years ago Closed 2 years ago

Crash in java.lang.IllegalArgumentException: packageName is not owned by the calling process at android.os.Parcel.readException(Parcel.java)

Categories

(Firefox for Android :: Audio/Video, defect, P1, critical)

Unspecified
Android
defect

Tracking

()

RESOLVED FIXED
Firefox 56
Tracking Status
fennec + ---
firefox54 --- wontfix
firefox55 --- fixed
firefox56 --- fixed

People

(Reporter: Grisha, Assigned: alwu)

Details

(Keywords: crash)

Crash Data

Attachments

(1 file)

This bug was filed from the Socorro interface and is 
report bp-6399d07a-50b6-478d-a4e9-8aa1b0170615.
=============================================================

Happens in MediaControlService#initMediaSession.
Alastor, could you take a look?
tracking-fennec: --- → ?
Flags: needinfo?(alwu)
Assignee: nobody → alwu
Flags: needinfo?(alwu)
Priority: -- → P1
review ping?
Thanks!
Flags: needinfo?(s.kaspari)
Comment on attachment 8879080 [details]
Bug 1373887 - catch exception to handle creating media session fail.

https://reviewboard.mozilla.org/r/150400/#review160760

Weird bug. Would be nice to know the cause though.

::: mobile/android/base/java/org/mozilla/gecko/media/MediaControlService.java:170
(Diff revision 2)
> -        initMediaSession();
> +        if (!initMediaSession()) {
> +             Log.e(LOGTAG, "initialization fail!");
> +             return;
> +        }

Do we want to stop the service here (stopSelf())?

::: mobile/android/base/java/org/mozilla/gecko/media/MediaControlService.java:293
(Diff revision 2)
> +        try {
> -        mSession = new MediaSession(getApplicationContext(),
> +            mSession = new MediaSession(getApplicationContext(),
> -                "fennec media session");
> +                                        "fennec media session");
> -        mController = new MediaController(getApplicationContext(),
> +            mController = new MediaController(getApplicationContext(),
> -                mSession.getSessionToken());
> +                                              mSession.getSessionToken());
> +        } catch (Exception e) {

Let's only catch IllegalStateException here.
Attachment #8879080 - Flags: review?(s.kaspari) → review+
Flags: needinfo?(s.kaspari)
(In reply to Sebastian Kaspari (:sebastian) from comment #7)
> Do we want to stop the service here (stopSelf())?

OK.

> Let's only catch IllegalStateException here.

OK, thanks for review!
Pushed by alwu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/d64895e3e0f3
catch exception to handle creating media session fail. r=sebastian
tracking-fennec: ? → +
[triage@0712] + as Alastor will working on it.
https://hg.mozilla.org/mozilla-central/rev/d64895e3e0f3
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Please request Beta approval on this when you get a chance.
Flags: needinfo?(alwu)
Comment on attachment 8879080 [details]
Bug 1373887 - catch exception to handle creating media session fail.

Approval Request Comment
[Feature/Bug causing the regression]: The feature, media control, was introduced in bug1240423
[User impact if declined]: fennec would crash
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No steps to reproduce
[List of other uplifts needed for the feature/fix]: No
[Is the change risky?]: No
[Why is the change risky/not risky?]: Just catching the exception, didn't add any new feature
[String changes made/needed]: No
Flags: needinfo?(alwu)
Attachment #8879080 - Flags: approval-mozilla-beta?
Comment on attachment 8879080 [details]
Bug 1373887 - catch exception to handle creating media session fail.

add exception handling to fix fennec crash, beta55+
Attachment #8879080 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.