1373887 - Crash in java.lang.IllegalArgumentException: packageName is not owned by the calling process at android.os.Parcel.readException(Parcel.java)

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Audio/Video, defect, P1)

Description

[:Grisha Kruglov]

This bug was filed from the Socorro interface and is 
report bp-6399d07a-50b6-478d-a4e9-8aa1b0170615.
=============================================================

Happens in MediaControlService#initMediaSession.

Comment 1

[:Grisha Kruglov]

Alastor, could you take a look?

Comment 2

[Alastor Wu [:alwu]]

Attachment: Bug 1373887 - catch exception to handle creating media session fail.

Review commit: https://reviewboard.mozilla.org/r/150400/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150400/

Comment 3

[Alastor Wu [:alwu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=24a2c64a44a0a351328c2897a0211470c80bca82

Comment 4

[Alastor Wu [:alwu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=a23d273f33356d104a2d5d8e522eab813dc59749

Comment 5

[Alastor Wu [:alwu]]

Comment on attachment 8879080 [details]
Bug 1373887 - catch exception to handle creating media session fail.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/150400/diff/1-2/

Comment 6

[Alastor Wu [:alwu]]

review ping?
Thanks!

Comment 7

[Sebastian Kaspari (:sebastian; :pocmo)]

Comment on attachment 8879080 [details]
Bug 1373887 - catch exception to handle creating media session fail.

https://reviewboard.mozilla.org/r/150400/#review160760

Weird bug. Would be nice to know the cause though.

::: mobile/android/base/java/org/mozilla/gecko/media/MediaControlService.java:170
(Diff revision 2)
> -        initMediaSession();
> +        if (!initMediaSession()) {
> +             Log.e(LOGTAG, "initialization fail!");
> +             return;
> +        }

Do we want to stop the service here (stopSelf())?

::: mobile/android/base/java/org/mozilla/gecko/media/MediaControlService.java:293
(Diff revision 2)
> +        try {
> -        mSession = new MediaSession(getApplicationContext(),
> +            mSession = new MediaSession(getApplicationContext(),
> -                "fennec media session");
> +                                        "fennec media session");
> -        mController = new MediaController(getApplicationContext(),
> +            mController = new MediaController(getApplicationContext(),
> -                mSession.getSessionToken());
> +                                              mSession.getSessionToken());
> +        } catch (Exception e) {

Let's only catch IllegalStateException here.

Comment 8

[Alastor Wu [:alwu]]

(In reply to Sebastian Kaspari (:sebastian) from comment #7)
> Do we want to stop the service here (stopSelf())?

OK.

> Let's only catch IllegalStateException here.

OK, thanks for review!

Comment 9

[Alastor Wu [:alwu]]

Comment on attachment 8879080 [details]
Bug 1373887 - catch exception to handle creating media session fail.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/150400/diff/2-3/

Comment 10

[Alastor Wu [:alwu]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=39fd2b079cb402d58bb440f4ce6ba2ea9c5821cd

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d64895e3e0f3
catch exception to handle creating media session fail. r=sebastian

Comment 12

[Wesly Huang (EPM)]

[triage@0712] + as Alastor will working on it.

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d64895e3e0f3

Comment 14

[Ryan VanderMeulen [:RyanVM]]

Please request Beta approval on this when you get a chance.

Comment 15

[Alastor Wu [:alwu]]

Comment on attachment 8879080 [details]
Bug 1373887 - catch exception to handle creating media session fail.

Approval Request Comment
[Feature/Bug causing the regression]: The feature, media control, was introduced in bug1240423
[User impact if declined]: fennec would crash
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No steps to reproduce
[List of other uplifts needed for the feature/fix]: No
[Is the change risky?]: No
[Why is the change risky/not risky?]: Just catching the exception, didn't add any new feature
[String changes made/needed]: No

Comment 16

[Julien Cristau [:jcristau]]

Comment on attachment 8879080 [details]
Bug 1373887 - catch exception to handle creating media session fail.

add exception handling to fix fennec crash, beta55+

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/589b643648db