Closed Bug 1373935 Opened 7 years ago Closed 7 years ago

Simplify help text for line number tool in CSS Grid Inspector Layout Panel

Categories

(DevTools :: Inspector, defect, P3)

Product:
DevTools
Component:
Inspector
Type:
defect

Tracking

(firefox56 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 56
Tracking Flags:
Tracking Status
firefox56 --- verified

People

(Reporter: jensimmons, Assigned: gl)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

1373935.patch [1.0]
2.39 KB, patch
pbro
: review+
Details | Diff | Splinter Review 
This is a simple fix. In the CSS Grid Inspector Layout Panel, the text for settings currently reads:
  [] Extend grid lines infinitely
  [] Display numbers on lines
  [] Display grid areas
https://monosnap.com/file/JvrZpcFjcQ68KZTP0YQhNqoJRbLQwY.png

I think it'd be more consistent to say 
[] Display line numbers

That is what they are called. The English is simpler, therefore better for a global audience. And it mirrors the third setting.
Summary: Simply help text for line number tool in CSS Grid Inspector Layout Panel → Simplify help text for line number tool in CSS Grid Inspector Layout Panel
Component: Developer Tools → Developer Tools: Inspector
Assignee: nobody → gl
Status: NEW → ASSIGNED
Priority: -- → P3

        Attachment #8879758 -
        Flags: review?(pbrosset)

        Attachment #8879758 -
        Flags: review?(pbrosset) → review+

    
    

    
  
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b40c0d688e5
Rename "Disply numbers on lines" to "Display line numbers" in the Grid Inspector. r=pbro

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/2b40c0d688e5
Status: ASSIGNED → RESOLVED
Closed: 7 years ago

          status-firefox56:
          --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56

    
    

    
  
I have reproduced this bug with Nightly 56.0a1 (2017-06-17) on Windows 8.1 , 64 Bit ! 

This bug's fix is Verified with latest Nightly 56.0a1 !

Build   ID    20170706060058
User Agent    Mozilla/5.0 (Windows NT 6.3; WOW64; rv:56.0) Gecko/20100101 Firefox/56.0

[bugday-20170705]

    
    

    
  
I have reproduced this bug with Nightly 56.0a1 (2017-06-17) (64-bit) on Ubuntu 16.04 LTS!

This bug's fix is verified with latest Beta 56.0b12!

Build ID   : 20170914024831
User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0
QA Whiteboard: [testday-20170915]

    
    

    
  
As per comment 4 and comment 5, I am marking this bug as Verified Fixed!
Status: RESOLVED → VERIFIED

          status-firefox56:
          fixed → verified

    
  
Product: Firefox → DevTools

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: