1374101 - Stop using the :not(:target) selector in sync-desktopIcon.svg and sync-mobileIcon.svg

Status: RESOLVED FIXED

(Firefox :: Theme, enhancement)

Comment 1

[Jonathan Watt [:jwatt]]

Attachment: Bug 1374101, part 1 - Convert chrome://browser/skin/sync-desktopIcon.svg and its consumers to use SVG image context paint.

Review commit: https://reviewboard.mozilla.org/r/150168/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150168/

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: Bug 1374101, part 2 - Convert chrome://browser/skin/sync-mobileIcon.svg and its consumers to use SVG image context paint.

Review commit: https://reviewboard.mozilla.org/r/150170/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/150170/

Comment 3

[Johann Hofmann [:johannh]]

Comment on attachment 8878934 [details]
Bug 1374101, part 1 - Convert chrome://browser/skin/sync-desktopIcon.svg and its consumers to use SVG image context paint.

https://reviewboard.mozilla.org/r/150168/#review155588

Looks good, thanks!

::: browser/themes/shared/sync-desktopIcon.svg:9
(Diff revision 1)
> -  <g id="icon-inverted" class="inverted">
> -    <path class="glyph" d="M15,14H1a1,1,0,0,1-1-1V12.526H16V13A1,1,0,0,1,15,14ZM1,4A1,1,0,0,1,2,3H14a1,1,0,0,1,1,1v8H1V4Zm1,7H14V4H2v7Z"/>
> -    <rect class="glyph translucent" x="2" y="4" width="12" height="7"/>
> -  </g>
>  </svg>
> +

Nit: please don't add a newline at the end of the file

Comment 4

[Johann Hofmann [:johannh]]

Comment on attachment 8878935 [details]
Bug 1374101, part 2 - Convert chrome://browser/skin/sync-mobileIcon.svg and its consumers to use SVG image context paint.

https://reviewboard.mozilla.org/r/150170/#review155620

::: browser/themes/shared/sync-mobileIcon.svg:9
(Diff revision 1)
> -  <g id="icon-inverted" class="inverted">
> -    <path class="glyph" d="M12,16H4a1,1,0,0,1-1-1V1A1,1,0,0,1,4,0h8a1,1,0,0,1,1,1V15A1,1,0,0,1,12,16Zm-4-.684a0.785,0.785,0,1,0-.785-0.785A0.785,0.785,0,0,0,8,15.316ZM12,2H4V13h8V2Z"/>
> -    <rect class="glyph translucent" x="4" y="2" width="8" height="11"/>
> -  </g>
>  </svg>
> +

Again, please remove the newline :)

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8c09d02e97d2
part 1 - Convert chrome://browser/skin/sync-desktopIcon.svg and its consumers to use SVG image context paint. r=johannh
https://hg.mozilla.org/integration/mozilla-inbound/rev/ae977ab5518b
part 2 - Convert chrome://browser/skin/sync-mobileIcon.svg and its consumers to use SVG image context paint. r=johannh

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/8c09d02e97d2
https://hg.mozilla.org/mozilla-central/rev/ae977ab5518b