Closed Bug 1374116 Opened 5 years ago Closed 5 years ago

EditorBase::GetFocusedContent() is slower than needed

Categories

(Core :: DOM: Editor, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: smaug, Assigned: smaug)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

EditorBase::GetFocusedContent() QIs, and before that
GetDOMEventTarget() has AddRefed, and then slow SameCOMIdentity() is used.
Assignee: nobody → bugs
Attachment #8879089 - Flags: review?(masayuki)
Comment on attachment 8879089 [details] [diff] [review]
getfocusedcontent.diff

Wow, tricky... GetDOMEventTarget() may return nsIDocument. However, in such case, content should refer different address. So, this should be safe.
Attachment #8879089 - Flags: review?(masayuki) → review+
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa2c280f4b3b
avoid some extra QIs in EditorBase::GetFocusedContent(), r=masayuki
https://hg.mozilla.org/mozilla-central/rev/aa2c280f4b3b
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.