EditorBase::GetFocusedContent() is slower than needed

RESOLVED FIXED in Firefox 56

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: smaug, Assigned: smaug)

Tracking

(Blocks: 1 bug)

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

EditorBase::GetFocusedContent() QIs, and before that
GetDOMEventTarget() has AddRefed, and then slow SameCOMIdentity() is used.
Assignee: nobody → bugs
Created attachment 8879089 [details] [diff] [review]
getfocusedcontent.diff
Attachment #8879089 - Flags: review?(masayuki)
Comment on attachment 8879089 [details] [diff] [review]
getfocusedcontent.diff

Wow, tricky... GetDOMEventTarget() may return nsIDocument. However, in such case, content should refer different address. So, this should be safe.
Attachment #8879089 - Flags: review?(masayuki) → review+

Comment 3

a year ago
Pushed by opettay@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/aa2c280f4b3b
avoid some extra QIs in EditorBase::GetFocusedContent(), r=masayuki

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/aa2c280f4b3b
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.