Closed Bug 1374119 Opened 2 years ago Closed 2 years ago
Codegen should use Bool
Var Cache and not Get Bool
Was this observed in profiles? In practice, this is only used in two cases: a [Pref] interface and a [Pref] dictionary member. The latter is quite rare. The former I was going to say would only happen once per page, but that may no longer be true with the changes we made in bug 1364816. I suppose we could generate a local static bool for this...
yes, I saw this in a profile while profiling Speedometer.
oops, wasn't going to take this one.
Assignee: bugs → nobody
Do you happen to recall what the callstack to the GetBool call was?
Hmm, can't recall exactly. It was when accessing some WebGL or *VR interface, but don't recall if it was just some script going through all the properties window has.
Assignee: nobody → bzbarsky
Status: NEW → ASSIGNED
Attachment #8879376 - Flags: review?(kyle) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/5f5e11c81db2 Use a bool pref cache for interface object enablement conditions instead of calling GetBool. r=qdot
You need to log in before you can comment on or make changes to this bug.