1374119 - Codegen should use BoolVarCache and not GetBool

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[Olli Pettay [:smaug][[e-mail]]]

http://searchfox.org/mozilla-central/rev/7cc377ce3f0a569c5c9b362d589705cd4fecc0ac/dom/bindings/Codegen.py#3454

Comment 1

[Boris Zbarsky [:bzbarsky]]

Was this observed in profiles?

In practice, this is only used in two cases: a [Pref] interface and a [Pref] dictionary member.  The latter is quite rare.  The former I was going to say would only happen once per page, but that may no longer be true with the changes we made in bug 1364816.

I suppose we could generate a local static bool for this...

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

yes, I saw this in a profile while profiling Speedometer.

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

oops, wasn't going to take this one.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Do you happen to recall what the callstack to the GetBool call was?

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Hmm, can't recall exactly. It was when accessing some WebGL or *VR interface, but
don't recall if it was just some script going through all the properties window has.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Attachment: Use a bool pref cache for interface object enablement conditions instead of calling GetBool

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/5f5e11c81db2
Use a bool pref cache for interface object enablement conditions instead of calling GetBool.  r=qdot

Comment 8

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/5f5e11c81db2