1374129 - Failing to initialise content script on popup window

Status: RESOLVED FIXED

(WebExtensions :: Frontend, defect)

Description

[mdew]

Attachment: 2017-06-18 12-02-20.avi

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
Build ID: 20170617103008

Steps to reproduce:

Using the Webextension Gesturefy; https://addons.mozilla.org/en-US/firefox/addon/gesturefy/

Visit:

http://www.top10tvboxes.com/s905x-vs-s905-which-is-faster-and-better-android-tv-box/

On the left hand side, click on 'Best Octa-core TV Boxes' under the "Best-sellers 2017" menu, this will open a new web page.

New web page won't allow gestures to work.

Video of the issue: https://www.youtube.com/watch?v=fkfT-KeaxV0

Issue report: https://github.com/Robbendebiene/Gesturefy/issues/13



Actual results:

Gesturefy fails to fire on new window.


Expected results:

Webextension should work with popup window.

Error received (https://github.com/Robbendebiene/Gesturefy/issues/13)

TypeError: context.contentWindow is null[Learn More]  ExtensionContent.jsm:317:9
TypeError: win is null[Learn More]  ExtensionUtils.jsm:143:3

Comment 1

[:shell escalante]

investigating

Comment 2

[Andy McKay]

If I remove match_about_blank in the manifest, this now works:


~/sandboxes/Gesturefy/src g diff
diff --git a/src/manifest.json b/src/manifest.json
index bbd961b..2dcb748 100644
--- a/src/manifest.json
+++ b/src/manifest.json
@@ -31,7 +31,6 @@
     {
       "matches": ["<all_urls>"],
       "run_at": "document_start",
-      "match_about_blank": true,
       "css": [
         "lib/injection.css"
       ],

Zombie any ideas?

Comment 3

[Tomislav Jovanovic :zombie]

Hm, if this is recent, it's likely fallout from bug 1368102.

Will investigate more.

Comment 4

[Tomislav Jovanovic :zombie]

The issue seems to be that when match_about_blank is on, we seem to be trying to inject into popup's about:blank document too early, before there's even a document there.

This might need to be fixed and uplifted soon, but I'm traveling tomorrow, so asking Kris agreed to take it.

Comment 6

[Kris Maglione [:kmag]]

Attachment: Bug 1374129: Avoid loading content scripts into uninitialized about:blank documents.

Review commit: https://reviewboard.mozilla.org/r/151572/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/151572/

Comment 7

[Andrew Swan [:aswan]]

Comment on attachment 8880201 [details]
Bug 1374129: Avoid loading content scripts into uninitialized about:blank documents.

https://reviewboard.mozilla.org/r/151572/#review156968

Trusting Kris's comment on IRC that a subsequent `"content-document-global-created"` should be triggered for an `about:blank` document that is uninitialized...

Comment 8

[Kris Maglione [:kmag]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/f01fd53c5e1cc3524e33e39cb7d2bf81820d4e61
Bug 1374129: Avoid loading content scripts into uninitialized about:blank documents. r=aswan

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/f01fd53c5e1c