Closed Bug 1374134 Opened 7 years ago Closed 7 years ago

Intermittent w3c-css/received/css-multicol-1/multicol-nested-column-rule-001.xht == w3c-css/received/css-multicol-1/multicol-nested-column-rule-001-ref.xht | image comparison, max difference: 255, number of differing pixels: 11455

Categories

(Core :: Layout, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED

People

(Reporter: intermittent-bug-filer, Assigned: neerja)

References

(Depends on 1 open bug)

Details

(Keywords: bulk-close-intermittents, intermittent-failure, Whiteboard: [stockwell unknown])

Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → INCOMPLETE
There are 41 failures in the last 7 days. They occur mostly on Windows-7-32 (enabled, disabled, nightly) and the affected build types are opt, debug, pgo. Here is a recent log example: https://treeherder.mozilla.org/logviewer.html#?repo=autoland&job_id=144088154&lineNumber=2755 And a relevant part of the log where the test failed: 12:21:10 INFO - REFTEST TEST-START | file:///Z:/task_1510488755/build/tests/reftest/tests/layout/reftests/w3c-css/received/css-multicol-1/multicol-nested-column-rule-001.xht == file:///Z:/task_1510488755/build/tests/reftest/tests/layout/reftests/w3c-css/received/css-multicol-1/multicol-nested-column-rule-001-ref.xht 2752 12:21:10 INFO - REFTEST TEST-LOAD | file:///Z:/task_1510488755/build/tests/reftest/tests/layout/reftests/w3c-css/received/css-multicol-1/multicol-nested-column-rule-001.xht | 262 / 487 (53%) 2753 12:21:10 INFO - REFTEST TEST-LOAD | file:///Z:/task_1510488755/build/tests/reftest/tests/layout/reftests/w3c-css/received/css-multicol-1/multicol-nested-column-rule-001-ref.xht | 262 / 487 (53%) 2754 12:21:10 INFO - REFTEST INFO | REFTEST fuzzy test (0, 0) <= (255, 11455) <= (225, 13600) 2755 12:21:10 ERROR - REFTEST TEST-UNEXPECTED-FAIL | file:///Z:/task_1510488755/build/tests/reftest/tests/layout/reftests/w3c-css/received/css-multicol-1/multicol-nested-column-rule-001.xht == file:///Z:/task_1510488755/build/tests/reftest/tests/layout/reftests/w3c-css/received/css-multicol-1/multicol-nested-column-rule-001-ref.xht | image comparison, max difference: 255, number of differing pixels: 11455 :jet, can you please take a look?
Flags: needinfo?(bugs)
Whiteboard: [stockwell needswork]
Neerja: these tests allow for a massive amount of fuzz. Do they actually test anything?
Flags: needinfo?(bugs) → needinfo?(npancholi)
(In reply to Jet Villegas (:jet) from comment #8) > Neerja: these tests allow for a massive amount of fuzz. Do they actually > test anything? I am going to hold off on answering this since the fix for Bug 616436 might mean we don't need this fuzzing anymore. I'm putting this bug in my queue to remind myself to get back to it after Bug 616436 is reviewed/resolved.
Assignee: nobody → npancholi
Flags: needinfo?(npancholi)
There have been 36 total failures in the last week. Occurrences per platform: - 35 Windows 7 - 1 windows7-32-stylo-disabled Occurrences per build type: - 15 opt - 13 pgo - 8 debug Here is a relevant recent log: https://treeherder.mozilla.org/logviewer.html#?repo=mozilla-inbound&job_id=147097810&lineNumber=2742 and a snippet from it: 12:21:03 INFO - REFTEST TEST-START | file:///Z:/task_1511438848/build/tests/reftest/tests/layout/reftests/w3c-css/received/css-multicol-1/multicol-nested-column-rule-001.xht == file:///Z:/task_1511438848/build/tests/reftest/tests/layout/reftests/w3c-css/received/css-multicol-1/multicol-nested-column-rule-001-ref.xht 2739 12:21:03 INFO - REFTEST TEST-LOAD | file:///Z:/task_1511438848/build/tests/reftest/tests/layout/reftests/w3c-css/received/css-multicol-1/multicol-nested-column-rule-001.xht | 259 / 487 (53%) 2740 12:21:03 INFO - REFTEST TEST-LOAD | file:///Z:/task_1511438848/build/tests/reftest/tests/layout/reftests/w3c-css/received/css-multicol-1/multicol-nested-column-rule-001-ref.xht | 259 / 487 (53%) 2741 12:21:03 INFO - REFTEST INFO | REFTEST fuzzy test (0, 0) <= (255, 11455) <= (225, 13600) 2742 12:21:03 ERROR - REFTEST TEST-UNEXPECTED-FAIL | file:///Z:/task_1511438848/build/tests/reftest/tests/layout/reftests/w3c-css/received/css-multicol-1/multicol-nested-column-rule-001.xht == file:///Z:/task_1511438848/build/tests/reftest/tests/layout/reftests/w3c-css/received/css-multicol-1/multicol-nested-column-rule-001-ref.xht | image comparison, max difference: 255, number of differing pixels: 11455 :neerja, could you please take a look? Thank you.
Flags: needinfo?(npancholi)
(In reply to Tiberius Oros[:tiberius_oros] from comment #11) > :neerja, could you please take a look? Thank you. Hi Tiberius, I took a few minutes to look at this test and off hand I am not sure why the horizontal scroll bar appears intermittently. Although, per comment 9, I am working on related functionality for Bug 616436 and I think it would be wise to hold off on this until then. Hopefully, I can give you a more helpful answer next week. Thanks!
Flags: needinfo?(npancholi)
There are 32 failures in the last 7 days. They occur on Windows 7 and windows7-32-nightly. The affected builds type are debug, opt and pgo. A recent log example: https://treeherder.mozilla.org/logviewer.html#?repo=autoland&job_id=153087526&lineNumber=2921 04:21:35 INFO - REFTEST TEST-START | file:///Z:/task_1513916195/build/tests/reftest/tests/layout/reftests/w3c-css/received/css-multicol-1/multicol-nested-column-rule-001.xht == file:///Z:/task_1513916195/build/tests/reftest/tests/layout/reftests/w3c-css/received/css-multicol-1/multicol-nested-column-rule-001-ref.xht 2918 04:21:35 INFO - REFTEST TEST-LOAD | file:///Z:/task_1513916195/build/tests/reftest/tests/layout/reftests/w3c-css/received/css-multicol-1/multicol-nested-column-rule-001.xht | 287 / 489 (58%) 2919 04:21:35 INFO - REFTEST TEST-LOAD | file:///Z:/task_1513916195/build/tests/reftest/tests/layout/reftests/w3c-css/received/css-multicol-1/multicol-nested-column-rule-001-ref.xht | 287 / 489 (58%) 2920 04:21:35 INFO - REFTEST INFO | REFTEST fuzzy test (0, 0) <= (255, 11455) <= (225, 13600) 2921 04:21:35 ERROR - REFTEST TEST-UNEXPECTED-FAIL | file:///Z:/task_1513916195/build/tests/reftest/tests/layout/reftests/w3c-css/received/css-multicol-1/multicol-nested-column-rule-001.xht == file:///Z:/task_1513916195/build/tests/reftest/tests/layout/reftests/w3c-css/received/css-multicol-1/multicol-nested-column-rule-001-ref.xht | image comparison, max difference: 255, number of differing pixels: 11455 2922 04:21:35 INFO - REFTEST IMAGE 1 (TEST): data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAyAAAAPoCAYAAAAmy5qxAAAXMElEQVR4nO3dW2pcyRZF0dN0NS17oqZkfckYuWTrsT1D2zkGLPRlcxFEhCcH6l53AACAyHX6fwAAAPA4BAgAAJARIAAAQEaAAAAAGQECAABkBAgAAJARIAAAQEaAAMdc1+wA/hb3FcxxBIBjPOjAFu4rmOMIAMd40IEt3FcwxxEAjvGgA1u4r2COIwAc40EHtnBfwRxHADjGgw5s4b6COY4AcIwHHdjCfQVzHAHgGA86sIX7CuY4AsAxHnRgC/cVzHEEgGM86MAW7iuY4wgAx3jQgS3cVzDHEQC :jet, can you please take at look at this?
Flags: needinfo?(bugs)
Whiteboard: [stockwell unknown] → [stockwell needswork]
There are 33 failures in the past 7 days. For the failure pattern see Comment 17 A recent log example: https://treeherder.mozilla.org/logviewer.html#?repo=autoland&job_id=155425068&lineNumber=2935 :jet, can you please take a look into this?
Whiteboard: [stockwell unknown] → [stockwell needswork]
(In reply to Cristina Coroiu [:ccoroiu] from comment #21) > There are 33 failures in the past 7 days. > For the failure pattern see Comment 17 > A recent log example: > https://treeherder.mozilla.org/logviewer. > html#?repo=autoland&job_id=155425068&lineNumber=2935 > :jet, can you please take a look into this? See comment 9.
Depends on: column-span
Flags: needinfo?(bugs)
Thanks to dholbert for pointing out that the test was wrong! I have fixed the test and created a pull request on github. Since this is a CSSWG test, the fix must be made upstream in the Web-platform-tests repo. Pull request - https://github.com/w3c/web-platform-tests/pull/9021
Depends on: 1430939
(In reply to Neerja Pancholi[:neerja] from comment #23) > Thanks to dholbert for pointing out that the test was wrong! > I have fixed the test and created a pull request on github. Since this is a > CSSWG test, the fix must be made upstream in the Web-platform-tests repo. > Pull request - > https://github.com/w3c/web-platform-tests/pull/9021 This pull request was approved and so the fixed test is now on w3c/web-platform-tests. The right way to update layout tests from this repo is to use import-tests.py script that bulk imports updates. So, I have created a helper Bug 1430939 to fix a bug in this script and then to update the latest version of all existing tests. Once the patches for Bug 1430939 are checked in, this bug will be fixed. (Added a bug dependency accordingly.)
Its been a week since the fix for Bug 1430939 landed and since there are no new reports of this failure happening since then, I am closing this bug as fixed.
Status: REOPENED → RESOLVED
Closed: 7 years ago7 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.